Skip to content

[ContainerRegistry] Generate .NET SDK for version 2025-03-01-preview #49345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 17, 2025
Merged

[ContainerRegistry] Generate .NET SDK for version 2025-03-01-preview #49345

merged 6 commits into from
Apr 17, 2025

Conversation

lizMSFT
Copy link
Member

@lizMSFT lizMSFT commented Apr 10, 2025 •
edited
Loading

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. labels Apr 10, 2025
@github-actions GitHub Actions
Copy link

Thank you for your contribution @lizMSFT! We will review the pull request and get back to you soon.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.ContainerRegistry

jsquire
jsquire previously requested changes Apr 11, 2025
View reviewed changes
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizMSFT:

Your account lacks the public GitHub organization memberships and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

@jsquire jsquire removed customer-reported Issues that are reported by GitHub users external to the Azure organization. Community Contribution Community members are working on the issue labels Apr 11, 2025
@lizMSFT lizMSFT requested a review from jsquire April 11, 2025 20:22
@lizMSFT
Copy link
Member Author

lizMSFT commented Apr 11, 2025

Hello @jsquire, I've set the organization membership to public and added the required permissions.

@jsquire
Copy link
Member

jsquire commented Apr 11, 2025

Hello @jsquire, I've set the organization membership to public and added the required permissions.

Confirmed. Account state looks good.

@jsquire jsquire dismissed their stale review April 11, 2025 20:35

Account issues confirmed resolved.

m5i-work
m5i-work reviewed Apr 14, 2025
View reviewed changes
Copy link
Member

@m5i-work m5i-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ArcturusZhang ArcturusZhang merged commit c970156 into Azure:main Apr 17, 2025
18 checks passed
@m5i-work m5i-work mentioned this pull request Apr 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

@m5i-work m5i-work m5i-work approved these changes

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@jsquire jsquire Awaiting requested review from jsquire

Assignees
No one assigned
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lizMSFT @azure-sdk @jsquire @ArcturusZhang @m5i-work