Skip to content

Support Maps Search API version 2025-01-01 #49130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025

Conversation

dubiety
Copy link
Member

@dubiety dubiety commented Mar 28, 2025

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@dubiety dubiety requested review from jsquire and Copilot March 28, 2025 09:12
@github-actions github-actions bot added the Maps label Mar 28, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Maps Search API to version 2025-01-01 by adapting the client options and API contracts and adding new address details such as StreetName and StreetNumber.

  • Updated API spec URL and service version configuration
  • Added assertions for new address fields in tests
  • Removed unused properties and attributes in model classes

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
sdk/maps/Azure.Maps.Search/tests/MapsSearchTests.cs Added assertions to verify new address fields in reverse geocoding tests
sdk/maps/Azure.Maps.Search/src/autorest.md Updated API spec URL for the new Search API version
sdk/maps/Azure.Maps.Search/src/Models/BoundaryInternal.cs Removed an unnecessary serialization attribute
sdk/maps/Azure.Maps.Search/src/Models/Boundary.cs Removed unused properties from the Boundary model
sdk/maps/Azure.Maps.Search/src/Models/AddressCountryRegion.Serialization.cs Removed obsolete serialization attribute for Iso
sdk/maps/Azure.Maps.Search/src/MapsSearchClientOptions.cs Updated the latest service version to V2_1
sdk/maps/Azure.Maps.Search/src/MapsSearchClient.cs Updated client constructors and method calls to support new address and coordinate handling
sdk/maps/Azure.Maps.Search/api/Azure.Maps.Search.netstandard2.0.cs Updated API contract with new service version and address fields
sdk/maps/Azure.Maps.Search/api/Azure.Maps.Search.net8.0.cs Updated API contract with new service version and address fields
sdk/maps/Azure.Maps.Search/CHANGELOG.md Documented breaking changes and new features introduced for Search API version 2025-01-01
Comments suppressed due to low confidence (1)

sdk/maps/Azure.Maps.Search/src/MapsSearchClient.cs:203

  • Invalid array initializer syntax: ensure that the array is initialized using curly braces '{}' instead of square brackets '[]'.
coordinates = coordinates = [

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Maps.Search

@dubiety
Copy link
Member Author

dubiety commented Apr 7, 2025

Hi @jsquire , can you help to review this PR? Much appreciated! :)

@jsquire
Copy link
Member

jsquire commented Apr 7, 2025

@dubiety: Please ensure that you've got at least one other member of your team onboarded to the repository and registered in CODEOWNERS for reviews. The Azure SDK team is needed to review changes outside of your /sdk/maps area, but anything that touches only your library should be reviewed/merged by your team directly.

In the meantime, I'll do a pass on this one so that you're not blocked.

@dubiety
Copy link
Member Author

dubiety commented Apr 8, 2025

Hi @jsquire ,

Thanks for the suggestion! I've updated CODEOWNERS for /sdk/maps in #49272 and also updated CHANGELOG by your comment. Can you help to review and approve #49272 and this PR? Thank you very much!

@jsquire
Copy link
Member

jsquire commented Apr 15, 2025

@dubiety: Apologies for the delay. Approved. Please yell if you need me to click the merge button.

@dubiety dubiety requested a review from andykao1213 April 15, 2025 22:54
@dubiety dubiety merged commit d3c5f39 into Azure:main Apr 16, 2025
33 checks passed
@dubiety dubiety deleted the users/charlie/upgrade-search branch April 16, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants