Skip to content

Apply SystemObjectTypeProvdier in Azure generator #49098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Apply SystemObjectTypeProvdier in Azure generator #49098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
238513d
Implement SystemObjectTypeProvdier to replace models with existing Az…
live1206 Mar 26, 2025
9976ddb
Merge branch 'main' into type-replacement
live1206 Apr 10, 2025
d239c3e
wip
live1206 Apr 10, 2025
64ff04b
Merge remote-tracking branch 'origin/main' into type-replacement
live1206 Apr 16, 2025
6575faf
adopt methods
live1206 Apr 16, 2025
2335969
Merge branch 'main' into type-replacement
live1206 Apr 24, 2025
7942c86
update
live1206 Apr 24, 2025
a1dad9b
update MTG generator
live1206 Apr 25, 2025
ecadd6b
revert change for mgmt
live1206 Apr 25, 2025
02726aa
Merge remote-tracking branch 'origin/main' into type-replacement
live1206 Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Packages.Data.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@
</ItemGroup>

<ItemGroup Condition="'$(IsGeneratorLibrary)' == 'true'">
<PackageReference Update="Microsoft.TypeSpec.Generator.ClientModel" Version="1.0.0-alpha.20250423.2" />
<PackageReference Update="Microsoft.TypeSpec.Generator.ClientModel" Version="1.0.0-alpha.20250425.1" />
<PackageReference Update="Azure.Generator" Version="1.0.0-alpha.20250423.3" />
<PackageReference Update="System.ClientModel" Version="1.3.0" />
</ItemGroup>
Expand Down
7 changes: 6 additions & 1 deletion eng/packages/http-client-csharp/generator/Azure.Generator/src/NamespaceVisitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ internal class NamespaceVisitor : ScmLibraryVisitor
{
protected override ModelProvider? PreVisitModel(InputModelType model, ModelProvider? type)
{
if (type is not null)
if (type is not null && type is not SystemObjectTypeProvider)
{
UpdateModelsNamespace(type);
}
Expand Down Expand Up @@ -54,6 +54,11 @@ internal class NamespaceVisitor : ScmLibraryVisitor

private static void UpdateModelsNamespace(TypeProvider type)
{
if (type is SystemObjectTypeProvider)
{
return;
}

if (AzureClientGenerator.Instance.Configuration.UseModelNamespace())
{
type.Type.Update(
Expand Down
Loading