StandbyPool package 2025-03-01 #48806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosh-msft2025
requested review from
ArcturusZhang and
ArthurMa1978
as code owners
github-actions
bot
added
the
Mgmt
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
Added some comments to Azure.ResourceManager.StandbyPool Please rename the SDK contracts accordingly |
…om/carlosh-msft2025/azure-sdk-for-net into dev/carlosh/standbypool-2025-03-01
live1206
reviewed
Apr 8, 2025
added 2 commits
April 8, 2025 21:24
…om/carlosh-msft2025/azure-sdk-for-net into dev/carlosh/standbypool-2025-03-01
live1206
previously approved these changes
Apr 10, 2025
live1206
dismissed
their stale review
The rename spec PR should be merged firstly
live1206
reviewed
Apr 11, 2025
sdk/standbypool/Azure.ResourceManager.StandbyPool/tsp-location.yaml
Outdated
Show resolved
Hide resolved
added 2 commits
April 10, 2025 18:17
live1206
reviewed
Apr 11, 2025
added 2 commits
April 10, 2025 21:52
live1206
reviewed
Apr 11, 2025
live1206
reviewed
Apr 11, 2025
|
@microsoft-github-policy-service agree company="Microsoft" |
|
@live1206 - Checks succeeded, please review / approve when available. Thanks! |
live1206
approved these changes
Apr 11, 2025
|
/check-enforcer override |
|
@ArthurMa1978 @ArcturusZhang Can I please get a vote on this PR? Thanks in advance |
ArcturusZhang
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.