Sync eng/common directory with azure-sdk-tools for PR 10579 #34262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the eng/common directory with the latest changes from azure-sdk-tools, enhancing support for automatic .env file handling for test resources. Key changes include the addition of a flag ($SupportsTestResourcesDotenv) to control .env file loading, the implementation of a bicep file linting function (LintBicepFile), and adjustments in the test resource scripts to improve .env file generation and removal.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/common/scripts/common.ps1 | Added a configuration flag for controlling automatic .env file loading. |
| eng/common/TestResources/TestResources-Helpers.ps1 | Introduced the LintBicepFile function and updated deployment output logic for .bicep. |
| eng/common/TestResources/Remove-TestResources.ps1 | Extended file removal logic to delete .env files generated by test resource scripts. |
| eng/common/TestResources/README.md | Updated documentation regarding the .env file requirements and gitignore configuration. |
| eng/common/TestResources/New-TestResources.ps1.md | Revised documentation to reflect updated OutFile behavior and file protection details. |
| eng/common/TestResources/New-TestResources.ps1 | Modified logic to conditionally enable OutFile based on Windows and dotenv support. |
azure-sdk
force-pushed
the
sync-eng/common-testresources-dotenv-10579
branch
from
88e96df to
7a1f9b6
Compare
If a language repo opts into it *and* if a `test-resources.bicep` file exists and lints clean of writing secrets *and* if the `.env` file is gitignore'd, write a `.env` file next to `test-resources.bicep`.
azure-sdk
force-pushed
the
sync-eng/common-testresources-dotenv-10579
branch
from
7a1f9b6 to
a0e02bb
Compare
heaths
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10579 See eng/common workflow