Rename Sorce Escaping #24288
Open
Rename Sorce Escaping #24288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashruti-msft
requested review from
souravgupta-msft,
jhendrixMSFT,
gapra-msft,
vibhansa-msft and
tanyasethi-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds preliminary logic to handle URL encoding for the destination path during file renaming and introduces a new test to validate the behavior when the destination string is unencoded.
- Added unescaping/escaping for the destination path in the Rename function.
- Introduced TestFileRenameWithoutEncoding in the test suite to validate rename behavior for unencoded destination paths.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/storage/azdatalake/file/client_test.go | New test added to verify file rename handling without prior encoding. |
| sdk/storage/azdatalake/file/client.go | Updated Rename function to incorporate URL unescaping/escaping. |
|
API change check API changes are not detected in this pull request. |
vibhansa-msft
approved these changes
Apr 4, 2025
|
/azp run go - azdatalake |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run go - azdatalake |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run go - azdatalake |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run go - azdatalake |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#23831