Skip to content

adding azure developer cli credential #21328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 10, 2023
Merged

adding azure developer cli credential #21328

merged 14 commits into from
Oct 10, 2023

Conversation

vhvb1989
Copy link
Member

@vhvb1989 vhvb1989 commented Aug 4, 2023 •
edited
Loading

By adding the azd-credential to the sdk-client, we will be able to use it for tools like terraform (hashicorp/terraform-provider-azurerm#22827) and kubernetes cli

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@vhvb1989 vhvb1989 self-assigned this Aug 4, 2023
chlowell
chlowell reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@chlowell chlowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@vhvb1989 vhvb1989 requested a review from chlowell August 8, 2023 17:55
chlowell
chlowell reviewed Aug 10, 2023
View reviewed changes
Copy link
Member

@chlowell chlowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some test coverage on main. If you rebase onto or merge it, I think this PR can clear the coverage bar now

@vhvb1989 vhvb1989 requested a review from a team as a code owner August 29, 2023 21:46
@scottaddie
Copy link
Member

@vhvb1989 Can you also please add a row to the table at https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azidentity/README.md#authenticating-via-development-tools?

@chlowell chlowell assigned chlowell and unassigned vhvb1989 Aug 30, 2023
@chlowell chlowell requested a review from jhendrixMSFT October 10, 2023 17:57
@chlowell chlowell merged commit 0669071 into Azure:main Oct 10, 2023
@chlowell chlowell mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottaddie scottaddie scottaddie left review comments

@chlowell chlowell chlowell left review comments

@RickWinter RickWinter RickWinter approved these changes

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner automatically assigned from Azure/azure-sdk-write-identity

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan ahsonkhan is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees

@chlowell chlowell

Labels
Azure.Identity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vhvb1989 @scottaddie @RickWinter @jhendrixMSFT @chlowell