Code generation for Azure Storage Files #19757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souravgupta-msft
requested review from
siminsavani-msft,
tasherif-msft and
jhendrixMSFT
as code owners
ghost
added
the
jhendrixMSFT
reviewed
Jan 5, 2023
|
Will we be able to directly export the generated code? |
|
We can probably expose all the models but I think we want some custom clients because there is are service, (sub)directory, and file clients that have relationships with each other similar to blob services, containers, and blobs. |
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Linter error is expected due to no contents in the root package. This will eventually go away. |
There was a problem hiding this comment.
@souravgupta-msft just as a final check please refer to the azure storage rest api docs to make sure generated APIs required/optional fields are mapped correctly, other than that this looks good
jhendrixMSFT
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.