Add unit test for simplified core.hpp header #824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhvb1989
requested review from
ahsonkhan,
antkmsft and
RickWinter
as code owners
vhvb1989
added
Azure.Core
Client
ahsonkhan
reviewed
Oct 21, 2020
ahsonkhan
reviewed
Oct 21, 2020
| /** | ||
| * @brief makes sure azure/core.hpp can be included. | ||
| * | ||
| * @remark This file will catch any issue while trying to use/include the core.hpp header |
ahsonkhan
approved these changes
Oct 21, 2020
|
Once we have samples that are built as part of CI, we can consider removing the test, since it won't ever fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests will ensure that if any header included by core.hpp gets broken (missing/removed/renamed/etc) then CI will catch it.
Compilation will fail