Remove unused included header from core within Identity that isn't available from the GA'd version of core #6042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsonkhan
requested review from
antkmsft,
schaabs,
RickWinter,
gearama,
LarryOsterman and
a team
as code owners
ahsonkhan
requested review from
maorleger,
christothes,
pvaneck,
billwert,
KarishmaGhiya and
mpodwysocki
ahsonkhan
changed the title
RickWinter
approved these changes
Sep 25, 2024
LarryOsterman
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remnant of the type move from earlier. The MICred API surface currently doesn't use this type and hence can be removed safely:
#5864
Currently the identity package depends on azure-core-cpp 1.9.0, which doesn't include this header:
azure-sdk-for-cpp/sdk/identity/azure-identity/vcpkg/vcpkg.json
Line 21 in 32db805
cc @4xicom