Improve test proxy sanitizers #4796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinming-Hu
added
test-enhancement
test-proxy
Jinming-Hu
requested review from
RickWinter,
ahsonkhan,
antkmsft,
vhvb1989,
gearama and
LarryOsterman
as code owners
|
@RickWinter @LarryOsterman @antkmsft @gearama @ahsonkhan can you help review this PR? Thanks |
RickWinter
approved these changes
Jul 24, 2023
microzchang
added a commit
that referenced
this pull request
Jul 27, 2023
* Set DOCKER_BUILDKIT to 1 in stress deploy image build (#4815) Co-authored-by: Ben Broderick Phillips <[email protected]> * Make x509 certificate script from azure-sdk-for-net common to repos (#4817) Co-authored-by: Ben Broderick Phillips <[email protected]> * improve test proxy sanitizers (#4796) * Storage test cases improvements (#4819) * soft delete test * enable setTierCold * IsConnectionReuse in record-playback mode * DISABLED_UploadPagesFromUriCrc64AccessCondition * update recording assets * ClientSecretCredentialWorks works in record-playback mode * ServiceContainerSasPermissions and ServiceBlobSasPermissions work in record-playback mode * BlobServiceClientTest.UserDelegationKey works in record-playback mode * update recordings * f --------- Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: JinmingHu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we:
addSanitizerand call this function for each sanitizer, instead of writing duplicate code many times.TestProxyManager::CheckSanitizersUriRegexSanitizeras it's already covered byGeneralRegexSanitizerHeaderRegexSanitizeras it's already covered byGeneralRegexSanitizer. Plus this was not correctly set and never worked. According to the source code,HeaderRegexSanitizerrequires akeywhich specifies which HTTP header this sanitizer applies to.Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.