Storage/feature/stg87-hns encryption context #4383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microzchang
requested review from
vinjiang,
katmsft,
Jinming-Hu,
EmmaZhu,
antkmsft,
vhvb1989,
gearama and
LarryOsterman
as code owners
Jinming-Hu
reviewed
Feb 23, 2023
sdk/storage/azure-storage-files-datalake/test/ut/datalake_file_client_test.cpp
Outdated
Show resolved
Hide resolved
…_client_test.cpp Co-authored-by: JinmingHu <[email protected]>
I checked Java SDK, it's not a required value(which is nullable in java). And I also asked @EmmaZhu , she also thought it's a nullable value. |
|
Sure, keep them nullable |
|
/azp run cpp - storage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Jinming-Hu
approved these changes
Feb 28, 2023
|
/check-enforcer override |
microzchang
added a commit
to microzchang/azure-sdk-for-cpp
that referenced
this pull request
Apr 4, 2023
* hns_encryption_context
microzchang
added a commit
to microzchang/azure-sdk-for-cpp
that referenced
this pull request
Apr 4, 2023
* hns_encryption_context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.