Skip to content

Compatibility improvement for striped blob #3932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Compatibility improvement for striped blob #3932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions sdk/storage/azure-storage-blobs/src/rest_client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6023,8 +6023,11 @@ namespace Azure { namespace Storage { namespace Blobs {
= Core::Convert::Base64Decode(pRawResponse->GetHeaders().at("x-ms-content-crc64"));
response.TransactionalContentHash.Value().Algorithm = HashAlgorithm::Crc64;
}
response.SequenceNumber
= std::stoll(pRawResponse->GetHeaders().at("x-ms-blob-sequence-number"));
if (pRawResponse->GetHeaders().count("x-ms-blob-sequence-number") != 0)
{
response.SequenceNumber
= std::stoll(pRawResponse->GetHeaders().at("x-ms-blob-sequence-number"));
}
response.IsServerEncrypted
= pRawResponse->GetHeaders().at("x-ms-request-server-encrypted") == std::string("true");
if (pRawResponse->GetHeaders().count("x-ms-encryption-key-sha256") != 0)
Expand Down Expand Up @@ -6132,8 +6135,11 @@ namespace Azure { namespace Storage { namespace Blobs {
response.LastModified = DateTime::Parse(
pRawResponse->GetHeaders().at("Last-Modified"), Azure::DateTime::DateFormat::Rfc1123);
}
response.SequenceNumber
= std::stoll(pRawResponse->GetHeaders().at("x-ms-blob-sequence-number"));
if (pRawResponse->GetHeaders().count("x-ms-blob-sequence-number") != 0)
{
response.SequenceNumber
= std::stoll(pRawResponse->GetHeaders().at("x-ms-blob-sequence-number"));
}
return Response<Models::ClearPagesResult>(std::move(response), std::move(pRawResponse));
}
Response<Models::UploadPagesFromUriResult> PageBlobClient::UploadPagesFromUri(
Expand Down Expand Up @@ -6292,8 +6298,11 @@ namespace Azure { namespace Storage { namespace Blobs {
= Core::Convert::Base64Decode(pRawResponse->GetHeaders().at("x-ms-content-crc64"));
response.TransactionalContentHash.Value().Algorithm = HashAlgorithm::Crc64;
}
response.SequenceNumber
= std::stoll(pRawResponse->GetHeaders().at("x-ms-blob-sequence-number"));
if (pRawResponse->GetHeaders().count("x-ms-blob-sequence-number") != 0)
{
response.SequenceNumber
= std::stoll(pRawResponse->GetHeaders().at("x-ms-blob-sequence-number"));
}
response.IsServerEncrypted
= pRawResponse->GetHeaders().at("x-ms-request-server-encrypted") == std::string("true");
if (pRawResponse->GetHeaders().count("x-ms-encryption-key-sha256") != 0)
Expand Down
20 changes: 20 additions & 0 deletions sdk/storage/azure-storage-blobs/swagger/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,26 @@ directive:
});
}
}
- from: swagger-document
where: $
transform: >
const operations = [
"PageBlob_UploadPages",
"PageBlob_ClearPages",
"PageBlob_UploadPagesFromUri",
];
for (const url in $["x-ms-paths"]) {
for (const verb in $["x-ms-paths"][url]) {
if (!operations.includes($["x-ms-paths"][url][verb].operationId)) continue;
const operation = $["x-ms-paths"][url][verb];

const status_codes = Object.keys(operation.responses).filter(s => s !== "default");
status_codes.forEach((status_code, i) => {
operation.responses[status_code].headers["x-ms-blob-sequence-number"]["x-ms-client-default"] = "int64_t()";
operation.responses[status_code].headers["x-ms-blob-sequence-number"]["x-nullable"] = true;
});
}
}
```

### GetBlobServiceProperties
Expand Down