Investigate whether an MSVC warning is a false positive - C26800 - Use of a moved from object: 'accessToken'

[ahsonkhan]

Try to create a simple repro of the warning and reach out to vcsig - the folks who own the C++ compiler to verify.

Before, which causes the warning in VS:

azure-sdk-for-cpp/sdk/identity/azure-identity/src/token_credential_impl.cpp

Lines 448 to 456 in 9271d13

	try
	{
	accessToken.ExpiresOn = parse(expiresOnAsString);
	return accessToken;
	}
	catch (std::exception const&)
	{
	// parse() has thrown, we may throw later.
	}

After, to workaround the warning:

azure-sdk-for-cpp/sdk/identity/azure-identity/src/token_credential_impl.cpp

Lines 449 to 457 in 7d463cd

	try
	{
	accessToken.ExpiresOn = parse(expiresOnAsString);
	// Workaround for Warning C26800 - Use of a moved from object: 'accessToken'
	// (lifetime.1) on MSVC version 14.40.33807+.
	// Returning accessToken here directly causes the warning.
	successfulParse = true;
	break;
	}

More context #5733 (comment)