-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Add new 2025-05-01-preview API version to Microsoft.Cdn for mTLS and Deployment Versions Public Preview #35440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…on to 2025-05-01-preview.
…; Update examples
Add change for preview deployment feature in 2025-05-01-preview
Next Steps to MergeNext steps that must be taken to merge this PR:
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
Cherry-picked public preview features mTLS and Deployment Versions from PR in private repo https://github.com/Azure/azure-rest-api-specs-pr/pull/22280, which has already received ARMSignedOff. Please refer to this PR for previous review comments. |
Fix model validation failed for deployment version files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check out the email titled "IMPORTANT: Your service is scheduled to be converted to TypeSpec in July". Any changes directly on swagger is not allowed. Contact "Janine Zhang [email protected]" and "Matthew Gertz [email protected]" for details.
why is this a POST ? looks like this is created a deploymentVersion. It should be PUT right ? It also has GET and PATCH APIs too. Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdx.json:3482 in ac96281. [](commit_id = ac96281, deletion_comment = False) |
have a verb+action format. say approveDeploymentVersion ? Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdx.json:3481 in ac96281. [](commit_id = ac96281, deletion_comment = False) |
have a verb+action format. say compareDeploymentVersion ? Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdx.json:3538 in ac96281. [](commit_id = ac96281, deletion_comment = False) |
Isn't that self-contradictory? How is it mutual if you don't know who the client is? Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdx.json:4501 in 13e1cf8. [](commit_id = 13e1cf8, deletion_comment = False) |
Could you walk me through the thinking around defaults here? If mTLS is better security, disabled by default doesn't sound very much like 'secure by default'. Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdx.json:5044 in 13e1cf8. [](commit_id = 13e1cf8, deletion_comment = False) |
I'd like to include you in some info I recently heard that crypto team wants us to stop supporting only SHA1 hashes, since SHA1 is no longer considered unforgeable. Can you please add support for other thumbprint algorithms? (not necessarily in this API version) In reply to: 3030821251 Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdx.json:5269 in 13e1cf8. [](commit_id = 13e1cf8, deletion_comment = False) |
is ISO 8601 the same as putting
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdx.json:5346 in 13e1cf8. [](commit_id = 13e1cf8, deletion_comment = False) |
In reply to: 3030829434 Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdx.json:5346 in 13e1cf8. [](commit_id = 13e1cf8, deletion_comment = False) |
So I guess you could go with "format": "date-time" then. In reply to: 3030837872 Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdx.json:5346 in 13e1cf8. [](commit_id = 13e1cf8, deletion_comment = False) |
wouldn't just 'createdAt' or 'creationTimeUtc' also follow naming guidelines? In reply to: 3014174663 Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdx.json:6248 in ac96281. [](commit_id = ac96281, deletion_comment = False) |
same, how about just 'approvalTimeUtc' or 'approvedAt' In reply to: 3014174688 Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdx.json:6253 in ac96281. [](commit_id = ac96281, deletion_comment = False) |
although.. does it sometimes really mean 'disapprovedAt'? (also, is approval one-way?) In reply to: 3030855521 Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdx.json:6253 in ac96281. [](commit_id = ac96281, deletion_comment = False) |
How about Rejected? Or Canceled? For people who don't want things to sit around unapproved forever but don't want to approve them? (or can't now because its too late) Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdx.json:6264 in 13e1cf8. [](commit_id = 13e1cf8, deletion_comment = False) |
So do they have to be SSL certs specifically? No magic self-signed certs here? Just wondering. |
I think its okay as is? CompareDeploymentVersions seems a bit redundant in the context of deploymentVersion resources? |
Overall comment regarding all the naming discussion, lets refer to |
...ce-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdwebapplicationfirewalldefinition.json
Show resolved
Hide resolved
...ce-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdwebapplicationfirewalldefinition.json
Show resolved
Hide resolved
...ce-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdwebapplicationfirewalldefinition.json
Show resolved
Hide resolved
...ce-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdwebapplicationfirewalldefinition.json
Show resolved
Hide resolved
...ce-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdwebapplicationfirewalldefinition.json
Show resolved
Hide resolved
...ce-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdwebapplicationfirewalldefinition.json
Show resolved
Hide resolved
...ce-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdwebapplicationfirewalldefinition.json
Show resolved
Hide resolved
...ce-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdwebapplicationfirewalldefinition.json
Show resolved
Hide resolved
...ce-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdwebapplicationfirewalldefinition.json
Show resolved
Hide resolved
...ce-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdwebapplicationfirewalldefinition.json
Show resolved
Hide resolved
Approval is one-way action, it does not mean disApproveAt |
...ce-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdwebapplicationfirewalldefinition.json
Show resolved
Hide resolved
...ce-manager/Microsoft.Cdn/preview/2025-05-01-preview/afdwebapplicationfirewalldefinition.json
Show resolved
Hide resolved
Thanks for sharing the common names guide. And yes I admit CreatedAt/ApprovedAt is better. May I ask is the renaming a MUST FIX? Because it will require to change code and re-deploy. Or can we wait for next version fix the naming? |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Cherry-picked public preview features mTLS and Deployment Versions from PR in private repo https://github.com/Azure/azure-rest-api-specs-pr/pull/22280, which has already received ARMSignedOff.
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.