-
Notifications
You must be signed in to change notification settings - Fork 5.4k
[TSP Migration][redis] TypeSpec migrated from swagger #35243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
/azp run SDK Validation - JS |
Azure Pipelines successfully started running 1 pipeline(s). |
*/ | ||
get is ArmResourceRead< | ||
PrivateEndpointConnection, | ||
Response = ArmResponse<Azure.ResourceManager.CommonTypes.PrivateEndpointConnection> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Azure.ResourceManager.CommonTypes.PrivateEndpointConnection is referred directly here and you define another PrivateEndpointConnection
in line 17. They are different model so SDK will generate 2 models. But they have same name, SDK generation will fail. Is it possible to refer to your defined model in Response? @melina5656
*/ | ||
createUpdate is ArmResourceCreateOrReplaceAsync< | ||
RedisCacheAccessPolicyAssignment, | ||
LroHeaders = ArmLroLocationHeader & Azure.Core.Foundations.RetryAfterHeader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing final result.
*/ | ||
createUpdate is ArmResourceCreateOrReplaceAsync< | ||
RedisCacheAccessPolicy, | ||
LroHeaders = ArmLroLocationHeader & Azure.Core.Foundations.RetryAfterHeader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing final result.
*/ | ||
put is ArmResourceCreateOrReplaceAsync< | ||
PrivateEndpointConnection, | ||
LroHeaders = ArmLroLocationHeader & Azure.Core.Foundations.RetryAfterHeader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing final result
This PR migrates your latest version (identified by the tag in your readme.md) of swagger to TypeSpec. We already tried our best to make sure the TypeSpec represents same as previous swagger. Since we lack the business knowledge, please validate this PR again to make sure it's functional equivalent as before. The local validation step is at Getting started | TypeSpec Azure
Besides, TypeSpec encourages to follow ARM guidelines. Therefore, some representations in your previous swagger will be fixed to follow these guidelines. When you see differences in your local validation, please keep this note in mind.
Please reach out to TypeSpec Discussions Channel if there is any help needed.