Skip to content

Convert Sql VirtualMachine swagger to Tsp #34268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Jul 4, 2025
Merged

Convert Sql VirtualMachine swagger to Tsp #34268

merged 34 commits into from
Jul 4, 2025

Conversation

mcgallan
Copy link
Member

@mcgallan mcgallan commented Apr 27, 2025 •
edited by pshao25
Loading

This PR migrates your latest version (identified by the tag in your readme.md) of swagger to TypeSpec. We already tried our best to make sure the TypeSpec represents same as previous swagger. Since we lack the business knowledge, please validate this PR again to make sure it's functional equivalent as before. The local validation step is at Getting started | TypeSpec Azure

Besides, TypeSpec encourages to follow ARM guidelines. Therefore, some representations in your previous swagger will be fixed to follow these guidelines. When you see differences in your local validation, please keep this note in mind.

Please reach out to TypeSpec Discussions Channel if there is any help needed.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 27, 2025 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 27, 2025 •
edited
Loading

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Apr 27, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 27, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.SqlVirtualMachine
TypeSpec Microsoft.SqlVirtualMachine
Go sdk/resourcemanager/sqlvirtualmachine/armsqlvirtualmachine
Python azure-mgmt-sqlvirtualmachine
Java com.azure.resourcemanager:azure-resourcemanager-sqlvirtualmachine
JavaScript @azure/arm-sqlvirtualmachine

@azure-sdk azure-sdk mentioned this pull request Apr 27, 2025
Closed
@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager TypeSpec Authored with TypeSpec labels Apr 27, 2025
This was referenced Apr 27, 2025
Closed
Closed
Closed
@azure-sdk azure-sdk mentioned this pull request Apr 27, 2025
Closed
@github-actions github-actions bot removed the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Apr 28, 2025
@pshao25 pshao25 marked this pull request as ready for review May 7, 2025 08:51
@azure-sdk azure-sdk mentioned this pull request May 8, 2025
Closed
@pshao25 pshao25 added BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. and removed NotReadyForARMReview labels Jun 19, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 30, 2025
@ramoka178
Copy link
Contributor

I think most of it looks fine to me.

  1. Swagger LintDiff has one error present in it. Please add a suppression in readme file for it or address the issue.
  2. Your previous "descriptions" for APIs are well documented and it feels bad to lose them.
    Could you check in https://teams.microsoft.com/l/channel/19%3A906c1efbbec54dc8949ac736633e6bdf%40thread.skype/TypeSpec%20Discussion?groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47 channel to see if you could retain the descriptions when moving to typespec.

@ramoka178 ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 30, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 30, 2025
@v-jiaodi v-jiaodi mentioned this pull request Jul 2, 2025
Open
23 tasks
@msyyc msyyc mentioned this pull request Jul 2, 2025
Open
21 tasks
@msyyc msyyc requested a review from weidongxu-microsoft July 4, 2025 04:46
@weidongxu-microsoft
Copy link
Member

lgtm

There is some diff on casing, but since Java haven't GAed it, we don't need to fix them.

@ArthurMa1978 ArthurMa1978 added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review PublishToCustomers Acknowledgement the changes will be published to Azure customers. labels Jul 4, 2025
@openapi-pipeline-app openapi-pipeline-app bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jul 4, 2025
@ArthurMa1978 ArthurMa1978 merged commit f3c8bc5 into Azure:main Jul 4, 2025
78 of 81 checks passed
danieljurek pushed a commit that referenced this pull request Jul 8, 2025
@mcgallan @danieljurek
Convert Sql VirtualMachine swagger to Tsp (#34268)
168e32d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshao25 pshao25 pshao25 left review comments

@ArthurMa1978 ArthurMa1978 ArthurMa1978 approved these changes

@weidongxu-microsoft weidongxu-microsoft Awaiting requested review from weidongxu-microsoft

Assignees
No one assigned
Labels
Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChange-Python-Sdk-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager TypeSpec Authored with TypeSpec typespec-conversion-w1 WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.