Skip to content

[TSP Migration][hybridkubernetes] TypeSpec migrated from swagger #34074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jul 4, 2025

Conversation

melina5656
Copy link
Member

@melina5656 melina5656 commented Apr 21, 2025

This PR migrates your latest version (identified by the tag in your readme.md) of swagger to TypeSpec. We already tried our best to make sure the TypeSpec represents same as previous swagger. Since we lack the business knowledge, please validate this PR again to make sure it's functional equivalent as before. The local validation step is at Getting started | TypeSpec Azure

Besides, TypeSpec encourages to follow ARM guidelines. Therefore, some representations in your previous swagger will be fixed to follow these guidelines. When you see differences in your local validation, please keep this note in mind. Here is the list of your anti-pattern:

  • Your common type version is still in v2. The lowest version of TypeSpec common type is v3.
  • Your operation list operation is not following arm guideline.
  • resourcegroups segment in your path will be normalized to resourceGroups

Please reach out to TypeSpec Discussions Channel if there is any help needed.

Copy link

openapi-pipeline-app bot commented Apr 21, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Apr 21, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

Copy link

github-actions bot commented Apr 21, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.Kubernetes
TypeSpec Microsoft.Kubernetes
Python azure-mgmt-hybridkubernetes
Java com.azure.resourcemanager:azure-resourcemanager-hybridkubernetes
JavaScript @azure/arm-hybridkubernetes
C# Azure.ResourceManager.Kubernetes

@ArthurMa1978
Copy link
Member

/azp run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@ArthurMa1978 ArthurMa1978 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 4, 2025
@openapi-pipeline-app openapi-pipeline-app bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required PipelineBotTrigger and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review PipelineBotTrigger labels Jul 4, 2025
@ArthurMa1978 ArthurMa1978 added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review PublishToCustomers Acknowledgement the changes will be published to Azure customers. and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 4, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 4, 2025
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 4, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 4, 2025
@ArthurMa1978 ArthurMa1978 merged commit 4379834 into main Jul 4, 2025
45 of 48 checks passed
@ArthurMa1978 ArthurMa1978 deleted the convert/hybridkubernetes branch July 4, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Python-Sdk-Approved PipelineBotTrigger PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager RPaaS TypeSpec Authored with TypeSpec typespec-conversion-w1 Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.