-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Kushalmehrotra713 migrate microsoft.migrate 2023 03 29 preview #27117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Kushalmehrotra713 migrate microsoft.migrate 2023 03 29 preview #27117
Conversation
…ion stable/2023-03-15 to version 2023-03-31-preview
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
migrate.json | 2023-03-31-preview(92e1724) | 2023-03-15(main) |
migrate.json | 2023-03-31-preview(92e1724) | 2017-11-11-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 17 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with the latest preview version:
Only 17 items are listed, please refer to log for more details.
Rule | Message |
---|---|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.Migrate/projects' removed or restructured? Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L1495:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}' removed or restructured? Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L1550:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/keys' removed or restructured? Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L1795:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/machines' removed or restructured? Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L1850:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/machines/{machineName}' removed or restructured? Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L1908:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/groups' removed or restructured? Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L1966:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/groups/{groupName}' removed or restructured? Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L2024:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/groups/{groupName}/assessments' removed or restructured? Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L2214:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/assessments' removed or restructured? Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L2275:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/groups/{groupName}/assessments/{assessmentName}' removed or restructured? Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L2333:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/groups/{groupName}/assessments/{assessmentName}/downloadUrl' removed or restructured? Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L2532:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/groups/{groupName}/assessments/{assessmentName}/assessedMachines' removed or restructured? Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L2593:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/groups/{groupName}/assessments/{assessmentName}/assessedMachines/{assessedMachineName}' removed or restructured? Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L2657:5 |
|
The new version is missing a definition that was found in the old version. Was 'Project' removed or renamed? New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L8739:3 Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L114:3 |
|
The new version is missing a definition that was found in the old version. Was 'AssessmentProperties' removed or renamed? New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L8739:3 Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L114:3 |
|
The new version is missing a client parameter that was found in the old version. Was 'subscriptionId' removed or renamed? New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L24555:3 Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L22:3 |
|
The new version is missing a client parameter that was found in the old version. Was 'resourceGroupName' removed or renamed? New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L24555:3 Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L22:3 |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌
LintDiff: 224 Errors, 7 Warnings failed [Detail]
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
package-preview-2023-03 | package-preview-2023-03(92e1724) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 17 items are listed, please refer to log for more details.
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L756 |
|
RequestBodyMustExistForPutPatch |
The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L779 |
RPC-Put-V1-28, RPC-Patch-V1-12 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L818 |
|
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L824 |
|
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L1750 |
|
RequestBodyMustExistForPutPatch |
The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L1773 |
RPC-Put-V1-28, RPC-Patch-V1-12 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L1812 |
|
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L1818 |
|
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L5796 |
|
RequestBodyMustExistForPutPatch |
The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L5819 |
RPC-Put-V1-28, RPC-Patch-V1-12 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L5866 |
|
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L5872 |
|
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L8588 |
|
RequestBodyMustExistForPutPatch |
The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L8611 |
RPC-Put-V1-28, RPC-Patch-V1-12 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L8650 |
|
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L8656 |
|
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L8760 |
RPC-Policy-V1-03 |
The following errors/warnings exist before current PR submission:
Only 17 items are listed, please refer to log for more details.
Rule | Message |
---|---|
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L328 |
RequestBodyMustExistForPutPatch |
The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L351 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L382 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L388 |
PatchPropertiesCorrespondToPutProperties |
tags property in patch body is not present in the corresponding put body. A patch request body must only contain properties present in the corresponding put request body, and must contain at least one of the properties. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L422 |
RequestBodyMustExistForPutPatch |
The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L422 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L453 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L3241 |
RequestBodyMustExistForPutPatch |
The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L3264 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L3303 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L3309 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L3494 |
RequestBodyMustExistForPutPatch |
The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L3517 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L3564 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L3570 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L4021 |
RequestBodyMustExistForPutPatch |
The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation. Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L4044 |
️❌
Avocado: 41 Errors, 0 Warnings failed [Detail]
Only 17 items are listed, please refer to log for more details.
Rule | Message |
---|---|
INCONSISTENT_API_VERSION |
The API version of the swagger is inconsistent with its file path. readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/preview/2023-03-31-preview/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Migrate/projects is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/preview/2017-11-11-preview/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Migrate/projects/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/preview/2017-11-11-preview/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Migrate/projects/{}/keys is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/preview/2017-11-11-preview/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/machines is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/preview/2017-11-11-preview/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/machines/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/preview/2017-11-11-preview/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/groups is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/preview/2017-11-11-preview/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/groups/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/preview/2017-11-11-preview/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/groups/{}/assessments is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/preview/2017-11-11-preview/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/assessments is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/preview/2017-11-11-preview/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/groups/{}/assessments/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/preview/2017-11-11-preview/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/groups/{}/assessments/{}/downloadUrl is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/preview/2017-11-11-preview/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/groups/{}/assessments/{}/assessedMachines is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/preview/2017-11-11-preview/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/groups/{}/assessments/{}/assessedMachines/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/preview/2017-11-11-preview/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/modernizeProjects/{}/deployedResources/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: MordernizeProjects/preview/2022-05-01-preview/migrateEngine.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/modernizeProjects/{}/deployedResources is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: MordernizeProjects/preview/2022-05-01-preview/migrateEngine.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/modernizeProjects/{}/migrateAgents/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: MordernizeProjects/preview/2022-05-01-preview/migrateEngine.json |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Hi @kushalmehrotra713! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
@AzureRestAPISpecReview why was the TypeSpec label added to this PR? I don't see any TypeSpec files in this. It's all Swagger and examples. |
@AzureRestAPISpecReview I removed the TypeSpec label because this PR contains no TypeSpec. |
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
ARMReview
label.Click here to see the diagram footnotes
Diagram footnotes
[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequested
is removed from your PR. This should cause the label
WaitForARMFeedback
to be added.[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting help
section below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.