Skip to content

Kushalmehrotra713 migrate microsoft.migrate 2023 03 29 preview #27117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kushalmehrotra713
Copy link
Contributor

@kushalmehrotra713 kushalmehrotra713 commented Dec 18, 2023

ARM (Control Plane) API Specification Update Pull Request

Tip: overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

  • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
  • You believe there is no need for you to request breaking change approval, for any reason.
    Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.
Click here to see the diagram footnotes

Diagram footnotes

[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Dec 18, 2023

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has at least one breaking change from a previous GA version (label: BreakingChangeReviewRequired). See the PR description for help.
  • ❌ The required check named Breaking Change(Cross-Version) has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 1 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Copy link

openapi-pipeline-app bot commented Dec 18, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 110 Errors, 152 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
migrate.json 2023-03-31-preview(92e1724) 2023-03-15(main)
migrate.json 2023-03-31-preview(92e1724) 2017-11-11-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Only 17 items are listed, please refer to log for more details.

Rule Message
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L413:9
Old: common-types/resource-management/v3/types.json#L411:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L225:9
Old: AssessmentProjects/stable/2023-03-15/migrate.json#L162:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L264:9
Old: AssessmentProjects/stable/2023-03-15/migrate.json#L201:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L306:9
Old: AssessmentProjects/stable/2023-03-15/migrate.json#L243:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L351:9
Old: AssessmentProjects/stable/2023-03-15/migrate.json#L288:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L422:9
Old: AssessmentProjects/stable/2023-03-15/migrate.json#L359:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L494:9
Old: AssessmentProjects/stable/2023-03-15/migrate.json#L431:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L1460:9
Old: AssessmentProjects/stable/2023-03-15/migrate.json#L478:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L1510:9
Old: AssessmentProjects/stable/2023-03-15/migrate.json#L528:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L1565:9
Old: AssessmentProjects/stable/2023-03-15/migrate.json#L583:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L1615:9
Old: AssessmentProjects/stable/2023-03-15/migrate.json#L633:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L3161:9
Old: AssessmentProjects/stable/2023-03-15/migrate.json#L688:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9


The following breaking changes are detected by comparison with the latest preview version:

Only 17 items are listed, please refer to log for more details.

Rule Message
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.Migrate/projects' removed or restructured?
Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L1495:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}' removed or restructured?
Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L1550:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/keys' removed or restructured?
Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L1795:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/machines' removed or restructured?
Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L1850:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/machines/{machineName}' removed or restructured?
Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L1908:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/groups' removed or restructured?
Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L1966:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/groups/{groupName}' removed or restructured?
Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L2024:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/groups/{groupName}/assessments' removed or restructured?
Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L2214:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/assessments' removed or restructured?
Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L2275:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/groups/{groupName}/assessments/{assessmentName}' removed or restructured?
Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L2333:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/groups/{groupName}/assessments/{assessmentName}/downloadUrl' removed or restructured?
Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L2532:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/groups/{groupName}/assessments/{assessmentName}/assessedMachines' removed or restructured?
Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L2593:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Migrate/projects/{projectName}/groups/{groupName}/assessments/{assessmentName}/assessedMachines/{assessedMachineName}' removed or restructured?
Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L2657:5
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Project' removed or renamed?
New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L8739:3
Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L114:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AssessmentProperties' removed or renamed?
New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L8739:3
Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L114:3
⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'subscriptionId' removed or renamed?
New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L24555:3
Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L22:3
⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'resourceGroupName' removed or renamed?
New: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L24555:3
Old: AssessmentProjects/preview/2017-11-11-preview/migrate.json#L22:3
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 224 Errors, 7 Warnings failed [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-preview-2023-03 package-preview-2023-03(92e1724) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Only 17 items are listed, please refer to log for more details.

Rule Message Related RPC [For API reviewers]
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L756
RequestBodyMustExistForPutPatch The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L779
RPC-Put-V1-28, RPC-Patch-V1-12
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L818
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L824
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L1750
RequestBodyMustExistForPutPatch The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L1773
RPC-Put-V1-28, RPC-Patch-V1-12
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L1812
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L1818
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L5796
RequestBodyMustExistForPutPatch The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L5819
RPC-Put-V1-28, RPC-Patch-V1-12
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L5866
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L5872
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L8588
RequestBodyMustExistForPutPatch The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L8611
RPC-Put-V1-28, RPC-Patch-V1-12
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L8650
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L8656
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L8760
RPC-Policy-V1-03


The following errors/warnings exist before current PR submission:

Only 17 items are listed, please refer to log for more details.

Rule Message
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L328
RequestBodyMustExistForPutPatch The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L351
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L382
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L388
PatchPropertiesCorrespondToPutProperties tags property in patch body is not present in the corresponding put body. A patch request body must only contain properties present in the corresponding put request body, and must contain at least one of the properties.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L422
RequestBodyMustExistForPutPatch The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L422
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L453
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L3241
RequestBodyMustExistForPutPatch The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L3264
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L3303
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L3309
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L3494
RequestBodyMustExistForPutPatch The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L3517
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L3564
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L3570
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L4021
RequestBodyMustExistForPutPatch The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation.
Location: AssessmentProjects/preview/2023-03-31-preview/migrate.json#L4044
️❌Avocado: 41 Errors, 0 Warnings failed [Detail]

Only 17 items are listed, please refer to log for more details.

Rule Message
INCONSISTENT_API_VERSION The API version of the swagger is inconsistent with its file path.
readme: specification/migrate/resource-manager/readme.md
json: AssessmentProjects/preview/2023-03-31-preview/migrate.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Migrate/projects is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: AssessmentProjects/preview/2017-11-11-preview/migrate.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Migrate/projects/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: AssessmentProjects/preview/2017-11-11-preview/migrate.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Migrate/projects/{}/keys is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: AssessmentProjects/preview/2017-11-11-preview/migrate.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/machines is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: AssessmentProjects/preview/2017-11-11-preview/migrate.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/machines/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: AssessmentProjects/preview/2017-11-11-preview/migrate.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/groups is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: AssessmentProjects/preview/2017-11-11-preview/migrate.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/groups/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: AssessmentProjects/preview/2017-11-11-preview/migrate.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/groups/{}/assessments is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: AssessmentProjects/preview/2017-11-11-preview/migrate.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/assessments is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: AssessmentProjects/preview/2017-11-11-preview/migrate.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/groups/{}/assessments/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: AssessmentProjects/preview/2017-11-11-preview/migrate.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/groups/{}/assessments/{}/downloadUrl is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: AssessmentProjects/preview/2017-11-11-preview/migrate.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/groups/{}/assessments/{}/assessedMachines is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: AssessmentProjects/preview/2017-11-11-preview/migrate.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/projects/{}/groups/{}/assessments/{}/assessedMachines/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: AssessmentProjects/preview/2017-11-11-preview/migrate.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/modernizeProjects/{}/deployedResources/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: MordernizeProjects/preview/2022-05-01-preview/migrateEngine.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/modernizeProjects/{}/deployedResources is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: MordernizeProjects/preview/2022-05-01-preview/migrateEngine.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/modernizeProjects/{}/migrateAgents/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: MordernizeProjects/preview/2022-05-01-preview/migrateEngine.json
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Dec 18, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed [Logs] Generate from 589b0df492c8204f1d5ee99429c0a33dcfeb9067. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
  • Azure.ResourceManager.Migrate [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️❌ azure-sdk-for-go failed [Detail]
  • Code Generator Failed [Logs] Generate from 589b0df492c8204f1d5ee99429c0a33dcfeb9067. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    cmderr	[generator automation-v2] [ERROR] total 1 error(s):
    cmderr	[generator automation-v2] [ERROR] failed to execute `go generate` '�[33;1mWARNING: Unable to find version for /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate�[0m
    cmderr	[generator automation-v2] [ERROR] Cannot find go module under resourcemanager/migrate/armmigrate, try to build in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate
    cmderr	[generator automation-v2] [ERROR] ##[command]Cleaning auto-generated files in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate
    cmderr	[generator automation-v2] [ERROR] ##[command]Executing autorest.go in  /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate
    cmderr	[generator automation-v2] [ERROR] autorest --use=@autorest/[email protected] --go --track2 --output-folder=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate --clear-output-folder=false --go.clear-output-folder=false --honor-body-placement=true --remove-unreferenced-types=false ./autorest.md
    cmderr	[generator automation-v2] [ERROR] AutoRest code generation utility [cli version: 3.6.1; node: v16.20.2]
    cmderr	[generator automation-v2] [ERROR] (C) 2018 Microsoft Corporation.
    cmderr	[generator automation-v2] [ERROR] https://aka.ms/autorest
    cmderr	[generator automation-v2] [ERROR] There is a new version of AutoRest available (3.7.1).
    cmderr	[generator automation-v2] [ERROR] > You can install the newer version with with npm install -g autorest@latest
    cmderr	[generator automation-v2] [ERROR] info    |    Loading AutoRest core      '/home/cloudtest/.autorest/@[email protected]/nodemodules/@autorest/core/dist' (3.10.1)
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] info    |    Installing AutoRest extension '@autorest/go' (4.0.0-preview.60 -> 4.0.0-preview.60)
    cmderr	[generator automation-v2] [ERROR] info    |    Installed AutoRest extension '@autorest/go' (4.0.0-preview.60->4.0.0-preview.60)
    cmderr	[generator automation-v2] [ERROR] info    |    Installing AutoRest extension '@autorest/modelerfour' (4.26.2 -> 4.26.2)
    cmderr	[generator automation-v2] [ERROR] info    |    Installed AutoRest extension '@autorest/modelerfour' (4.26.2->4.26.2)
    cmderr	[generator automation-v2] [ERROR] error   | [Exception] No input files provided.
    cmderr	[generator automation-v2] [ERROR] Use --help to get help information or see https://aka.ms/autorest/cli for additional documentation
    cmderr	[generator automation-v2] [ERROR] error   |   Error: [Exception] No input files provided.
    cmderr	[generator automation-v2] [ERROR] Use --help to get help information or see https://aka.ms/autorest/cli for additional documentation
    cmderr	[generator automation-v2] [ERROR] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
    cmderr	[generator automation-v2] [ERROR] ##[error]Error running autorest.go
    cmderr	[generator automation-v2] [ERROR] build.go:5: running "pwsh": exit status 1
    cmderr	[generator automation-v2] [ERROR] ': exit status 1
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
    warn	Skip package processing as generation is failed
️🔄 azure-sdk-for-js inProgress [Detail]
️❌ azure-resource-manager-schemas failed [Detail]
  • Pipeline Framework Failed [Logs] Generate from 589b0df492c8204f1d5ee99429c0a33dcfeb9067. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.5
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.5>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cannot force update branch 'sdkAuto/27117/migrate' as it is the current HEAD of the repository.
    Error: cannot force update branch 'sdkAuto/27117/migrate' as it is the current HEAD of the repository.
  • ️✔️migrate [View full logs]  [Preview Schema Changes]
  • ️✔️migrate [View full logs
    error	Fatal error: cannot force update branch 'sdkAuto/27117/migrate' as it is the current HEAD of the repository.
    error	The following packages are still pending:
    error		migrate
    error		migrate
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs] Generate from 589b0df492c8204f1d5ee99429c0a33dcfeb9067. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ⚠️Az.migrate.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.migrate.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Dec 18, 2023

Generated ApiView

Language Package Name ApiView Link
Swagger Microsoft.Migrate https://apiview.dev/Assemblies/Review/4e09eb1608934c26b5bb3860525e1a98?revisionId=f508d3a49095449b8a3cb051085447c7

Copy link

Hi @kushalmehrotra713! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

@AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Dec 18, 2023
@tjprescott
Copy link
Member

@AzureRestAPISpecReview why was the TypeSpec label added to this PR? I don't see any TypeSpec files in this. It's all Swagger and examples.

@tjprescott tjprescott removed the TypeSpec Authored with TypeSpec label Feb 28, 2024
@tjprescott
Copy link
Member

@AzureRestAPISpecReview I removed the TypeSpec label because this PR contains no TypeSpec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-MissingBaseCommit new-api-version resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants