[Hub Generated] Review request for Microsoft.AzureStackHCI to add version preview/2023-11-01-preview #26885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…023-08-01-preview to version 2023-11-01-preview
|
PR validation pipeline started successfully. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
|
PR validation pipeline started successfully. This comment will be populated with the 'Swagger Validation Report' |
|
PR validation pipeline started successfully. This comment will be populated with the 'Swagger Generation Artifacts' report |
|
PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| arcSettings.json | 2023-11-01-preview(681ce85) | 2023-08-01(main) |
| arcSettings.json | 2023-11-01-preview(681ce85) | 2023-08-01-preview(main) |
| clusters.json | 2023-11-01-preview(681ce85) | 2023-08-01(main) |
| clusters.json | 2023-11-01-preview(681ce85) | 2023-08-01-preview(main) |
| deploymentSettings.json | 2023-11-01-preview(681ce85) | 2023-08-01-preview(main) |
| edgeDevices.json | 2023-11-01-preview(681ce85) | 2023-08-01-preview(main) |
| extensions.json | 2023-11-01-preview(681ce85) | 2023-08-01(main) |
| extensions.json | 2023-11-01-preview(681ce85) | 2023-08-01-preview(main) |
| offers.json | 2023-11-01-preview(681ce85) | 2023-08-01(main) |
| offers.json | 2023-11-01-preview(681ce85) | 2023-08-01-preview(main) |
| operations.json | 2023-11-01-preview(681ce85) | 2023-08-01(main) |
| operations.json | 2023-11-01-preview(681ce85) | 2023-08-01-preview(main) |
| publishers.json | 2023-11-01-preview(681ce85) | 2023-08-01(main) |
| publishers.json | 2023-11-01-preview(681ce85) | 2023-08-01-preview(main) |
| skus.json | 2023-11-01-preview(681ce85) | 2023-08-01(main) |
| skus.json | 2023-11-01-preview(681ce85) | 2023-08-01-preview(main) |
| updateRuns.json | 2023-11-01-preview(681ce85) | 2023-08-01(main) |
| updateRuns.json | 2023-11-01-preview(681ce85) | 2023-08-01-preview(main) |
| updateSummaries.json | 2023-11-01-preview(681ce85) | 2023-08-01(main) |
| updateSummaries.json | 2023-11-01-preview(681ce85) | 2023-08-01-preview(main) |
| updates.json | 2023-11-01-preview(681ce85) | 2023-08-01(main) |
| updates.json | 2023-11-01-preview(681ce85) | 2023-08-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 40 Errors, 276 Warnings failed [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| package-preview-2023-11 | package-preview-2023-11(681ce85) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 30 items are listed, please refer to log for more details.
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/arcSettings.json#L120 |
RPC-Async-V1-11, RPC-Put-V1-11 |
|
The property 'tags' in the request body either not apppear in the resource model or has the wrong level. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/arcSettings.json#L189 |
RPC-Patch-V1-03 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/arcSettings.json#L218 |
RPC-Delete-V1-01 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/arcSettings.json#L242 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/arcSettings.json#L351 |
RPC-Async-V1-07 |
|
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/arcSettings.json#L409 |
RPC-Async-V1-11, RPC-Async-V1-14 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/arcSettings.json#L441 |
RPC-Async-V1-07 |
|
Missing identifier id in array item property Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/arcSettings.json#L607 |
|
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/clusters.json#L159 |
RPC-Async-V1-11, RPC-Put-V1-11 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/clusters.json#L257 |
RPC-Delete-V1-01 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/clusters.json#L286 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/clusters.json#L338 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/clusters.json#L387 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/clusters.json#L445 |
RPC-Async-V1-07 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/edgeDevices.json#L194 |
RPC-Delete-V1-01 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/extensions.json#L227 |
RPC-Async-V1-07 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/extensions.json#L247 |
RPC-Delete-V1-01 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/extensions.json#L274 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/extensions.json#L332 |
RPC-Async-V1-07 |
|
Missing identifier id in array item property Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/extensions.json#L448 |
|
|
Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/offers.json#L134 |
RPC-Get-V1-08 |
|
Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/skus.json#L92 |
RPC-Get-V1-08 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/updateRuns.json#L83 |
RPC-Delete-V1-01 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/updateRuns.json#L112 |
RPC-Async-V1-07 |
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/updateRuns.json#L139 |
RPC-Async-V1-11, RPC-Put-V1-11 |
|
A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/updateRuns.json#L139 |
|
|
Tracked resource 'UpdateRun' must have patch operation that at least supports the update of tags. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/updateRuns.json#L255 |
RPC-Patch-V1-03 |
|
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/updates.json#L38 |
RPC-Async-V1-11, RPC-Async-V1-14 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/updates.json#L64 |
RPC-Async-V1-07 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.AzureStackHCI/preview/2023-11-01-preview/updates.json#L132 |
RPC-Delete-V1-01 |
️❌Avocado: 27 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/galleryImages/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/galleryImages.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/galleryImages is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/galleryImages.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.AzureStackHCI/galleryImages is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/galleryImages.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/marketplaceGalleryImages/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/marketplaceGalleryImages.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/marketplaceGalleryImages is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/marketplaceGalleryImages.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.AzureStackHCI/marketplaceGalleryImages is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/marketplaceGalleryImages.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/networkInterfaces/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/networkInterfaces.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/networkInterfaces is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/networkInterfaces.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.AzureStackHCI/networkInterfaces is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/networkInterfaces.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/storageContainers/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/storageContainers.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/storageContainers is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/storageContainers.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.AzureStackHCI/storageContainers is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/storageContainers.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/virtualHardDisks/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/virtualHardDisks.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/virtualHardDisks is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/virtualHardDisks.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.AzureStackHCI/virtualHardDisks is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/virtualHardDisks.json |
|
The default tag should contain all APIs. The API path /{}/providers/Microsoft.AzureStackHCI/virtualMachineInstances/default is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/virtualMachineInstances.json |
|
The default tag should contain all APIs. The API path /{}/providers/Microsoft.AzureStackHCI/virtualMachineInstances/default/start is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/virtualMachineInstances.json |
|
The default tag should contain all APIs. The API path /{}/providers/Microsoft.AzureStackHCI/virtualMachineInstances/default/stop is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/virtualMachineInstances.json |
|
The default tag should contain all APIs. The API path /{}/providers/Microsoft.AzureStackHCI/virtualMachineInstances/default/restart is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/virtualMachineInstances.json |
|
The default tag should contain all APIs. The API path /{}/providers/Microsoft.AzureStackHCI/virtualMachineInstances is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/virtualMachineInstances.json |
|
The default tag should contain all APIs. The API path /{}/providers/Microsoft.AzureStackHCI/virtualMachineInstances/default/hybridIdentityMetadata/default is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/virtualMachineInstances.json |
|
The default tag should contain all APIs. The API path /{}/providers/Microsoft.AzureStackHCI/virtualMachineInstances/default/hybridIdentityMetadata is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/virtualMachineInstances.json |
|
The default tag should contain all APIs. The API path /{}/providers/Microsoft.AzureStackHCI/virtualMachineInstances/default/guestAgents/default is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/virtualMachineInstances.json |
|
The default tag should contain all APIs. The API path /{}/providers/Microsoft.AzureStackHCI/virtualMachineInstances/default/guestAgents is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/virtualMachineInstances.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/logicalNetworks/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/logicalNetworks.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AzureStackHCI/logicalNetworks is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/logicalNetworks.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.AzureStackHCI/logicalNetworks is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/azurestackhci/resource-manager/readme.md json: Microsoft.AzureStackHCI/preview/2023-09-01-preview/logicalNetworks.json |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
new-api-version
resource-manager
RPaaS
WaitForARMFeedback
sjanamma
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
please fix duplicate schemas: |
added 2 commits
December 4, 2023 10:43
|
@sjanamma Please provide LintDiff Suppression and Approved Suppression tags as well. |
AzureRestAPISpecReview
added
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
This reverts commit 688b3a5.
AzureRestAPISpecReview
removed
the
BreakingChangeReviewRequired
priyjain358
added
the
WaitForARMFeedback
openapi-workflow-bot
bot
removed
the
ARMChangesRequested
Alancere
added
the
Approved-SdkBreakingChange-Go
|
/pr RequestMerge |
rkmanda
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
rkmanda
added
WaitForARMFeedback
openapi-workflow-bot
bot
removed
the
ARMSignedOff
rkmanda
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
rkmanda
deleted the
priyjain358-azurestackhci-Microsoft.AzureStackHCI-2023-11-01-preview-main
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
ARMReviewlabel.Click here to see the diagram footnotes
Diagram footnotes
[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.