Add the missing description to summarization parameter #20809
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,10 +16,7 @@ | |
| "description": "The error object.", | ||
| "$ref": "#/definitions/Error" | ||
| } | ||
| } | ||
| }, | ||
| "Error": { | ||
| "type": "object", | ||
|
|
@@ -805,7 +802,8 @@ | |
| "properties": { | ||
| "sentenceCount": { | ||
| "type": "integer", | ||
| "format": "int32", | ||
| "description": "It controls the approximate number of sentences in the output summaries." | ||
| }, | ||
| "stringIndexType": { | ||
| "$ref": "#/definitions/StringIndexType" | ||
|
|
@@ -1540,12 +1538,11 @@ | |
| }, | ||
| "parameters": { | ||
| "Endpoint": { | ||
| "name": "endpoint", | ||
| "description": "Supported Cognitive Services endpoint (e.g., https://<resource-name>.api.cognitiveservices.azure.com).", | ||
| "x-ms-parameter-location": "client", | ||
| "required": true, | ||
| "type": "string", | ||
|
There was a problem hiding this comment. This is to make consistent with July preview. Is that OK? @heaths There was a problem hiding this comment. For anything new, I recommend declaring the There was a problem hiding this comment. @heaths there are so many conflict rules and I'm confused which rule trump which rule... This is existing stuff, not new. In /specification folder, the latest stable version and the latest preview has no format, only /dev folder has format uri. Given we cannot break anything GA, we should fix /dev folder as what I'm doing here - remove format uri, right? |
||
| "in": "path", | ||
| "x-ms-skip-url-encoding": true | ||
| }, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |
| "info": { | ||
| "title": "Microsoft Cognitive Language Service - Question Answering - Authoring", | ||
| "description": "The language service API is a suite of natural language processing (NLP) skills built with best-in-class Microsoft machine learning algorithms. The API can be used to analyze unstructured text for tasks such as sentiment analysis, key phrase extraction, language detection and question answering. Further documentation can be found in <a href=\"https://docs.microsoft.com/en-us/azure/cognitive-services/text-analytics/overview\">https://docs.microsoft.com/en-us/azure/cognitive-services/text-analytics/overview</a>.", | ||
| "version": "2022-10-01-preview" | ||
| }, | ||
| "securityDefinitions": { | ||
| "AADToken": { | ||
|
|
@@ -32,7 +32,7 @@ | |
| } | ||
| ], | ||
| "x-ms-parameterized-host": { | ||
|
There was a problem hiding this comment. Can we know the reason for this change ? There was a problem hiding this comment. It causes validation error. Let me revert this, and request exception. There was a problem hiding this comment. Standalone fix for this: #20927 |
||
| "hostTemplate": "{Endpoint}/language", | ||
| "useSchemePrefix": false, | ||
| "parameters": [ | ||
| { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In /specification folder, the latest stable is uppercase "Endpoint", and latest preview is lowercase "endpoint", so no matter what we do here, it is a breaking change. So I will revert this to keep it in uppercase "Endpoint" so no breaking change to GA version. @heaths, Is that OK?