Skip to content

Refactor semantic error handling and add tests for validation #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

AsafMah
Copy link
Collaborator

@AsafMah AsafMah commented Dec 30, 2024

Fixes #557

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Copy link

github-actions bot commented Dec 30, 2024

Test Results

    5 files  ± 0      5 suites  ±0   16m 33s ⏱️ + 2m 45s
  296 tests + 2    262 ✅ + 2   34 💤 ±0  0 ❌ ±0 
1 480 runs  +10  1 310 ✅ +10  170 💤 ±0  0 ❌ ±0 

Results for commit 2c06bc7. ± Comparison against base commit 6bbba52.

♻️ This comment has been updated with latest results.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (4)

azure-kusto-data/tests/test_e2e_data.py:390

  • The test_semantic_error method should cover more cases, such as different types of semantic errors or different responses.
def test_semantic_error(self):

azure-kusto-data/tests/test_e2e_data.py:397

  • The test_semantic_error_async method should cover more cases, such as different types of semantic errors or different responses.
async def test_semantic_error_async(self):

azure-kusto-data/azure/kusto/data/exceptions.py:30

  • Ensure that the string 'Semantic error:' is consistently replaced with the constant SEMANTIC_ERROR_STRING throughout the codebase.
SEMANTIC_ERROR_STRING = "Semantic error:"

azure-kusto-data/azure/kusto/data/exceptions.py:46

  • Add a test case to ensure that self.message_text is correctly set and used in the is_semantic_error method.
self.message_text = messages if isinstance(messages, str) else "\n\n".join(repr(m) for m in messages)

@AsafMah AsafMah merged commit c409c3b into master Jan 7, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_semantic_error Method Fails with TypeError When Using aiohttp.ClientResponse in KustoServiceError Class
1 participant