-
Notifications
You must be signed in to change notification settings - Fork 109
Refactor semantic error handling and add tests for validation #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (4)
azure-kusto-data/tests/test_e2e_data.py:390
- The test_semantic_error method should cover more cases, such as different types of semantic errors or different responses.
def test_semantic_error(self):
azure-kusto-data/tests/test_e2e_data.py:397
- The test_semantic_error_async method should cover more cases, such as different types of semantic errors or different responses.
async def test_semantic_error_async(self):
azure-kusto-data/azure/kusto/data/exceptions.py:30
- Ensure that the string 'Semantic error:' is consistently replaced with the constant SEMANTIC_ERROR_STRING throughout the codebase.
SEMANTIC_ERROR_STRING = "Semantic error:"
azure-kusto-data/azure/kusto/data/exceptions.py:46
- Add a test case to ensure that self.message_text is correctly set and used in the is_semantic_error method.
self.message_text = messages if isinstance(messages, str) else "\n\n".join(repr(m) for m in messages)
Fixes #557