Fix df from result table error message + old types #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_from_result_table func
AsafMah
requested changes
Jun 18, 2024
| if isinstance(converter, str): | ||
| frame[column_name] = frame[column_name].astype(converter) | ||
| else: | ||
| if converter is None: |
There was a problem hiding this comment.
move this before the isinstance
| @@ -18,14 +18,22 @@ def default_dict() -> Converter: | |||
| return { | |||
There was a problem hiding this comment.
Add a test with an alias name, and with a missing type name
ohadbitt
previously approved these changes
Jun 18, 2024
| if isinstance(converter, str): | ||
| frame[column_name] = frame[column_name].astype(converter) | ||
| else: | ||
| if converter is None: |
There was a problem hiding this comment.
Move None check before isinstance
…ub.com/Azure/azure-kusto-python into fix_df_from_result_table_error_message
AsafMah
reviewed
Jun 18, 2024
| assert type(df_int_to_float.iloc[0].RecordInt) is numpy.float64 | ||
| assert df.iloc[0].RecordInt == 5678 | ||
|
|
||
| # Testing missing type conversion | ||
| raised = False |
AsafMah
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed error message in case of none existing type
added old type names in kusto to default dictionary #542