Clean up data (drop created table) after running E2E tests #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I remove a separate function that drops the table which was executed before starting the tests. Since the generated table name includes a second-based timestamp, this should only be necessary if the previous execution was *started* within 1 second of the current execution, including the time it took to create the table. As surprising as that might be (even if it failed immediately after creating the table and was then reexecuted), the function must've been added when this or some other situation that made this necessary was encountered. Adding randomness to the table's name should solve the same issue, but faster to reduce the E2E's already long runtime.
yogilad
requested changes
Sep 22, 2020
| @@ -144,14 +142,13 @@ def get_file_path() -> str: | |||
| test_db = os.environ.get("TEST_DATABASE") | |||
|
|
|||
| python_version = "_".join([str(v) for v in sys.version_info[:3]]) | |||
| test_table = "python_test_{0}_{1}".format(python_version, str(int(time.time()))) | |||
| test_table = "python_test_{0}_{1}_{2}".format(python_version, str(int(time.time())), random.randint(1, 100000)) | |||
There was a problem hiding this comment.
I used random because I thought a UUID would be overkill. Aren't Python UUIDs 36 characters long? And wouldn't it take longer for Python to generate its 32 (not including dashes) random characters than to generate 5 random digits?
There was a problem hiding this comment.
I also considered using a random int instead of the python version and time components, but I think the 1st two fields are helpful to identify what (and when) created rogue Kusto tables.
There was a problem hiding this comment.
Probably, but is sends a clearer intent.
optional comment, not a must
yogilad
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Clean up data (drop created table) after running E2E tests.
I remove a separate function that drops the table which was executed before starting the tests. Since the generated table name includes a second-based timestamp, this should only be necessary if the previous execution was started within 1 second of the current execution, including the time it took to create the table. As surprising as that might be (even if it failed immediately after creating the table and was then reexecuted), the function must've been added when this or some other situation that made this necessary was encountered. Adding randomness to the table's name should solve the same issue, but faster to reduce the E2E's already long runtime.