ci: [Service Tags] add public ips with service tags for LBs during cluster creation #3277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Pull request closed due to inactivity. |
|
reopening PR |
Signed-off-by: Keerthana Routhu <[email protected]>
Signed-off-by: Keerthana Routhu <[email protected]>
jpayne3506
approved these changes
Apr 7, 2025
rbtr
approved these changes
Apr 7, 2025
jpayne3506
added
release/1.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adding service tags to all public ips. This change adds public ips and attaches these ips as load balancer outbound ips during cluster creation. Branch
spathak/add-service-tagsis where all the changes were made and tested -- created this branch based off of that one.Testing:
spathak/add-service-tagsTested changes in a couple of Cilium pipelines:
Cilium Nightly Pipeline
The public ips created have service tags attached to them, and the ips fall within the allowed ranges for the locations they were created. E2E tests are failing in this run and in master too, so failures aren't bc of these changes.
CNI Release Test
All of the public ips created have service tags attached to them, and the ips fall within the allowed ranges for the locations they were created
CNI - LSG Integration Test
The clusters get created here successfully with the correct public ips. The integration tests do fail, but I checked with John Payne -- he mentioned that the integration tests fail frequently because they're heavily dependent on a partner team (Canonical). He suggested running Cilium Private Test pipelines on v1.14 and v1.16 (the next two on the list) and the remaining pipelines with the service tags. The remaining pipelines look good and create public ips as expected, so I believe we should be good to go on that front.
ACN PR Pipeline
All of the public ips created have service tags attached to them, and the ips fall within the allowed ranges for the locations they were created