Skip to content

Add resourceTags parameter documentation for HCIBox #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Mar 6, 2025
Merged

Conversation

janegilring
Copy link
Contributor

@janegilring janegilring commented Mar 6, 2025

This pull request includes updates to the documentation for the Azure Jumpstart HCIBox project. The changes focus on improving clarity and consistency in the documentation, updating terminology, and ensuring accurate instructions for deployment.

Key changes include:

Documentation Updates:

  • Updated network details tables to improve readability and consistency in docs/azure_jumpstart_hcibox/AKS/_index.md and docs/azure_jumpstart_hcibox/RB/_index.md [1] [2].
  • Changed references from "Azure CLI" to "Azure Bicep" to reflect the current deployment method in docs/azure_jumpstart_hcibox/cloud_deployment/_index.md, docs/azure_jumpstart_hcibox/deployment_az/_index.md, and docs/azure_jumpstart_hcibox/getting_started/_index.md [1] [2] [3].
  • Updated the deployment instructions to include a detailed parameters table for the main.bicepparam file in docs/azure_jumpstart_hcibox/deployment_az/_index.md.

Terminology and Clarity Improvements:

  • Corrected terminology and added clarity to the deployment steps and validation instructions in docs/azure_jumpstart_hcibox/cloud_deployment/_index.md [1] [2].
  • Updated the description of HCIBox components to use the term "Azure Local machine" instead of "HCI node" in docs/azure_jumpstart_hcibox/using_hcibox/_index.md.

janegilring and others added 19 commits March 4, 2025 17:07
Signed-off-by: Jan Egil Ring <[email protected]>
…LI in getting started documentation

Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Add resourceTags parameter documentation for HCIBox
@janegilring janegilring self-assigned this Mar 6, 2025
@janegilring janegilring added the HCIBox Jumpstart HCIBox related label Mar 6, 2025
@janegilring janegilring added this to the March 2025 milestone Mar 6, 2025
@janegilring janegilring requested a review from likamrat March 6, 2025 06:07
@sebassem sebassem self-requested a review March 6, 2025 09:18
Copy link
Contributor

@sebassem sebassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janegilring janegilring merged commit 2c98509 into main Mar 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HCIBox Jumpstart HCIBox related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants