This repository was archived by the owner on Jan 14, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
swap tests to use jest and separate e2e and unit tests #56
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't worth it. Let's just use Mocha 🐙. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Swap tests to use jest and separate them into e2e tests and unit tests. Jest is preferred over mocha because that's what our team has experience with. Separating e2e and unit tests makes sense to reduce testing feedback loop time + makes the repository more organized.
microsoft/vscode-test#59 Here's some discussion on how to do it for vs-code (and some interesting jest vs mocha discussion). In most metrics jest has greatly surpassed mocha.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
These are testing changes. They run both locally and on the github runner. They have been checked in both failure and success cases. If tests fail, the cli returns a non 0 exit code and the opposite for successes.
Checklist: