Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the two memory leaks I currently found in this repository:
strdup()
in src/linux/InotifyEventLoop.cppuv_async_send()
will yield an execution of the callback (Document).mEventCallbackAsync
may not be called. As a result,EventBaton
and its events won't be freed bycleanupEventCallback()
This pull request currently fixed the first leaks.
Related to #72