Skip to content

feat: Add axserialport wrapper and example #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

apljungquist
Copy link
Collaborator

No description provided.

@apljungquist apljungquist requested a review from Copilot May 13, 2025 21:04
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new wrapper for the Axis Serial Port API and provides an example application demonstrating its usage. Key changes include the implementation of the axserialport wrapper with safe Rust abstractions and binding generation for low‐level FFI, as well as updates to the workspace configuration to integrate the new crates.

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
crates/axserialport/src/lib.rs Implements Rust wrapper functions for the Axis Serial Port API.
crates/axserialport/src/gio.rs Provides GIO-related functionality using the new serial port bindings.
crates/axserialport-sys/* Adds low-level bindings and build script for FFI with axserialport API.
apps/axserialport_example/src/main.rs An example application showcasing the use of the serial port wrapper.
Makefile & Cargo.toml Updated to include the new crates in the workspace.

@apljungquist apljungquist changed the title Add axserialport wrapper and example feat: Add axserialport wrapper and example May 13, 2025
@apljungquist
Copy link
Collaborator Author

apljungquist commented May 20, 2025

I have been able to test that this doesn't crash. However, since I don't have a camera with a serial port, and I can't connect a loopback cable to the cameras as the instructions say from the virtual loan tool, I'm afraid I'm stuck. Are either of you interested in finishing this example? @guoxe @kjughx

@kjughx
Copy link
Contributor

kjughx commented May 21, 2025

Are either of you interested in finishing this example?

As in continuing development or just test if it works?

@apljungquist
Copy link
Collaborator Author

If it compiles, it works. Right? 😅

More likely it will need a few test-fix cycles, so I was thinking the same person would do both to avoid slow handovers and context switching. If it doesn't sound like fun, maybe you know someone who is interested in taking a Free(ky) Friday to learn ACAP/Rust...

I'm eager to help us much as I can, be it by doing the development, pair programming or just answer questions. And I'm not partial to what I built, I only want a PoC for the last API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants