Support existing VPCs #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avx-mmcspadden
previously requested changes
Jul 15, 2024
There was a problem hiding this comment.
Add in comments for skipped Checkov's: https://www.checkov.io/2.Basics/Suppressing%20and%20Skipping%20Policies.html
|
Is there a way to bulk ignore or disable Checkov for this PR? We'll address the errors as we work on the HA code in the future. |
|
What is blocking this PR from being merged now? |
|
@trvsmtchll I think it just needs your approval stamp and then it can merge |
trvsmtchll
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.