Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust caret rectangle for scroll offset #489

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adjust caret rectangle for scroll offset #489

wants to merge 2 commits into from

Conversation

realybin
Copy link
Contributor

Fixes #352

Before this pr

before

After this pr

after

Gillibald
Gillibald approved these changes Feb 16, 2025
View reviewed changes
Copy link
Contributor

@Gillibald Gillibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@realybin realybin marked this pull request as draft February 18, 2025 10:34
@realybin
Copy link
Contributor Author

I meet some issues while my mate test this pr. I'm investigating it.

@realybin
Copy link
Contributor Author

realybin commented Feb 18, 2025 •
edited
Loading

image
The similar problem occurs with the TextBox in the search box, but this existed before I submitted this pr, and after modifying it, this pr didn't make this function correctly, and it's common sense that the TextBox should be displayed correctly as expected. Why is this? What are your thoughts on this please? @Gillibald @danipen

Update
Seems that the problem is a new thread, the _searchTextBox's CursorRectangle is not affected by _textArea it's
cursorRectangleProperty, I set a break point in it's get but no hits while I'm press the key.

@realybin realybin marked this pull request as ready for review February 18, 2025 12:47
@d3ara1n
Copy link

d3ara1n commented Mar 8, 2025

Any updates? I have ran into the same problem :sad:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gillibald Gillibald Gillibald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IME BUG：After scrolling, the Chinese input method does not work properly
4 participants
@realybin @d3ara1n @Gillibald @danipen