Fix DataGrid SelectionChanged event not raised after 3 right clicks #6948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
maxkatz6
approved these changes
Jan 7, 2022
donandren
pushed a commit
to donandren/Avalonia
that referenced
this pull request
Jan 11, 2022
…id-right-click-selection Fix DataGrid SelectionChanged event not raised after 3 right clicks
ltetak
pushed a commit
to ltetak/Avalonia
that referenced
this pull request
Jan 14, 2022
…ght-click-selection Fix DataGrid SelectionChanged event not raised after 3 right clicks
maxkatz6
added a commit
that referenced
this pull request
Jan 18, 2022
…selection Fix DataGrid SelectionChanged event not raised after 3 right clicks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fix DataGrid.SelectionChanged event not raised after you right click 3 different rows.
What is the current behavior?
Currently after 3 right clicks on different rows, the SelectionChanged event is not raised anymore for neither left or right click on any of the data grid's rows.
From a code perspective, the NoSelectionChangeCount is decremented, without initially being incremented, in the method UpdateStateOnMouseRightButtonDown. This will set the NoSelectionChangeCount to be negative (-1 on first right click, -2 on 2nd right click, etc), and after 3 right clicks, the NoSelectionChangeCount will never reach 0 value, which would have raised the event.
What is the updated/expected behavior with this PR?
After multiple right clicks on different DataGrid rows, the SelectionChanged event is still fired after left or right click on a row.
How was the solution implemented (if it's not obvious)?
Added the (missing) increment in the UpdateStateOnMouseRightButtonDown method.
Fixed issues
#6898