Implement IPlatformLifetimeEvents for X11/Linux #6883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacato
force-pushed
the
linux-shutdown-prevention-xsmp
branch
from
4cd8a54 to
1ae2e36
Compare
danwalmsley
requested changes
Nov 12, 2021
| private static readonly SMLib.IceWatchProc s_iceWatchProcDelegate = IceWatchHandler; | ||
|
|
||
| private bool AllowShutdownCancellation => | ||
| Environment.GetEnvironmentVariable("AVALONIA_X11_USE_SESSION_MANAGER") != "0"; |
There was a problem hiding this comment.
Wouldn't it be better to add a configuration in AppBuilder instead of an environment variable?
There was a problem hiding this comment.
No, this is only intended to be like other X11 switches we already have. @kekekeks and @danwalmsley made this suggestion.
There was a problem hiding this comment.
@jmacato that switch should live in X11PlatformOptions with default value determined by environment variable.
danwalmsley
added a commit
that referenced
this pull request
Nov 23, 2021
Implement IPlatformLifetimeEvents for X11/Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Allows users to interrupt the shutdown event in Linux via X Session Management Protocol.
Screen.Recording.2021-11-09.at.12.23.22.AM.mp4
What is the current behavior?
There was no way to inhibit shutdowns on Linux, unlike on win/macOS.