remove win32 dialog dpi hack #18923
Merged
remove win32 dialog dpi hack #18923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grokys
approved these changes
May 26, 2025
|
You can test this PR using the following package version. |
MrJul
added
bug
backport-candidate-11.3.x
MrJul
pushed a commit
that referenced
this pull request
Jun 5, 2025
Co-authored-by: Steven Kirk <[email protected]>
MrJul
added
backported-11.3.x
and removed
backport-candidate-11.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Remove a dpi hack added here, #16143 . This is no longer needed, as toplevels now invalidate themselves when there's any dpi changes. The issue the hack was fixing is properly fixed here #18315 .
What is the current behavior?
When a dialog window is opened, because no dpi updates are sent to it when the dialog parent is set, the dialog toplevel doesn't invalidate its visual, thus it will use the default 1x scale when rendering.
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #18921
Fixes #18903