Fix focus not being lost when a parent element is hidden #18916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
TomEdwardsEnscape
force-pushed
the
fixes/clear-focus-when-not-effectivelyvisible
branch
from
69b6ef2 to
d04beaf
Compare
|
You can test this PR using the following package version. |
… hidden Enabled the relevant test
TomEdwardsEnscape
force-pushed
the
fixes/clear-focus-when-not-effectivelyvisible
branch
from
d04beaf to
e440f50
Compare
TomEdwardsEnscape
changed the title
|
You can test this PR using the following package version. |
MrJul
added
bug
backport-candidate-11.3.x
MrJul
pushed a commit
that referenced
this pull request
Jun 5, 2025
… hidden (#18916) Enabled the relevant test
MrJul
added
backported-11.3.x
and removed
backport-candidate-11.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InputElementnow clears focus from child elements whenIsVisiblechanges to false. Previously, it only cleared focus from itself.The
FocusManager.ClearFocusOnElementRemovedmethod is now called, withFocusManager.ClearFocusused only as a fallback in case we can't provide parameters (which would indicate an invalid state). This seems sensible to me since as far as the focus manager is concerned, a hidden element has been removed.The
Focus_Should_Be_Cleared_When_Control_Is_Effectively_Hiddentest has also been enabled.Breaking changes
None.
Obsoletions / Deprecations
None.
Fixed issues
Fixes #18817