Fix RadialGradientBrush GradientStop reordering #18907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
grokys
approved these changes
May 26, 2025
Gillibald
added
the
backport-candidate-11.3.x
Gillibald
added a commit
to Gillibald/Avalonia
that referenced
this pull request
May 27, 2025
Gillibald
added a commit
to Gillibald/Avalonia
that referenced
this pull request
May 27, 2025
Gillibald
added a commit
to Gillibald/Avalonia
that referenced
this pull request
May 27, 2025
3 tasks
maxkatz6
added
backported-11.3.x
and removed
backport-candidate-11.3.x
maxkatz6
pushed a commit
that referenced
this pull request
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR makes sure gradient stops are correctly reordered when the center and origin are not the same.
What is the current behavior?
Currently, under some conditions gradient stops do not have a valid value after reordering because of some rounding error, etc.
What is the updated/expected behavior with this PR?
I have added some validation to the ImmutableGradientStop ctor so offsets are always valid. The Skia RadianGradientBrush creation was adjusted to avoid rounding errors. A proper condition for rerordering was added and the optional reordering was optimize to avoid Linq
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues