-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fix insets on android 15 #18844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix insets on android 15 #18844
Conversation
You can test this PR using the following package version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignoring values in property setters is technically a huge hack since it breaks expectations about properties.
Consider changing IInsetsManager to reflect this.
- Add
DisplayEdgeToEdgePreference
property for setting application's preference - Add read-only
DisplaysEdgeToEdge
property that reflects the actual value - Mark the old
DisplayEdgeToEdge
property as obsolete, setter would controlDisplayEdgeToEdgePreference
, getter would readDisplaysEdgeToEdge
- (optional) Add SupportedEdgeToEdgeModes property
@kekekeks |
547f723
to
b92af59
Compare
Added |
b92af59
to
4076bcc
Compare
4076bcc
to
5b375cb
Compare
5b375cb
to
f1ca995
Compare
You can test this PR using the following package version. |
@emmauss can we keep backport candidate label for 11.x? So we could remove old API in 12.0 |
That would be ok. |
You can test this PR using the following package version. |
* fix insets on android 15 * add api diff * fix nit
What does the pull request do?
Disables updating any system bar properties when setting display edge to edge on Android 15. It is also not possible to change system bar color on android 15. This change only affects projects targeting net9 and above.
More information about the new behavior here #18835 .
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
IInsetsManager
has a new propertyDisplayEdgeToEdgePreference
andDisplaysEdgeToEdge
.Obsoletions / Deprecations
IInsetsManager.DisplayEdgeToEdge
is deprecated forIInsetsManager.DisplayEdgeToEdgePreference
Fixed issues
Fixes #18835