Fix an issue where input controls initialized with InputMethod.IsInputMethodEnable=false could still use IME in their initial state.
#18816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In `Imm32InputMethod.cs`, removed the premature assignment to `_langId` within the `SetLanguageAndWindow` method to ensure subsequent logic correctly recognizes langId changes and properly updates the IME state. - Fixed an issue where input controls initialized with `InputMethod.IsInputMethodEnable=false` could still use IME in their initial state.
|
You can test this PR using the following package version. |
|
maxkatz6
approved these changes
May 8, 2025
maxkatz6
added
bug
os-windows
backport-candidate-11.3.x
|
@cla-avalonia agree |
MrJul
pushed a commit
that referenced
this pull request
Jun 5, 2025
- In `Imm32InputMethod.cs`, removed the premature assignment to `_langId` within the `SetLanguageAndWindow` method to ensure subsequent logic correctly recognizes langId changes and properly updates the IME state. - Fixed an issue where input controls initialized with `InputMethod.IsInputMethodEnable=false` could still use IME in their initial state.
MrJul
added
backported-11.3.x
and removed
backport-candidate-11.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes incorrect IME state management when initializing input controls with disabled IME. The changes ensure proper language ID tracking and IME state updates.
What is the current behavior?
InputMethod.IsInputMethodEnable=falsecan still use IME in their initial state_langIdassignment inSetLanguageAndWindowprevents proper detection of language ID changesWhat is the updated/expected behavior with this PR?
InputMethod.IsInputMethodEnable=falseSetLanguageAndWindowmethodHow was the solution implemented (if it's not obvious)?
_langIdassignment inImm32InputMethod.SetLanguageAndWindowIsInputMethodEnablesettingChecklist
Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
Fixes #11273