Fix crash with samsung keyboard when using password textboxes #18793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmauss
added
os-android
backport-candidate-11.3.x
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
May 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
MrJul
pushed a commit
that referenced
this pull request
Jun 5, 2025
MrJul
added
backported-11.3.x
and removed
backport-candidate-11.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fix a crash on samsung keyboards on android when using password textbox. Internally, samsung keyboard casts the
ICharSequencereturned in all extracted text to aJava.Lang.Stringtype, but only when the input connection is initialized with password input type. We previously returnedSpannableString, which though is anICharSequence, is not aJava.Lang.String, thus crashing the ime. We now return aJava.Lang.String. We weren't applying spans to out returning strings, so no functional difference between the two string types.Other imes were and are not affected by the type returned.
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #18772