You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request addresses an issue where the IME CandidateWindow is not correctly positioned when using Pinyin IMEs on Windows. The fix ensures that the CandidateWindow aligns properly with the caret position, improving user experience when typing Chinese characters with Pinyin Input Method Editors.
What is the current behavior?
The CandidateWindow's top position does not align correctly with the caret position. This behavior is inconsistent with most major UI frameworks and leads to a poor user experience when inputting Chinese characters using Pinyin IMEs.
This issue was observed in different Chinese IMEs, including older ones on Windows 7.
What is the updated/expected behavior with this PR?
The CandidateWindow now aligns correctly with the caret position. This behavior has been tested on multiple Chinese IMEs, including those available on Windows 7, and all display as expected.
The fix ensures compatibility across various IMEs and improves usability.
How was the solution implemented (if it's not obvious)?
Most Chinese input methods after Windows XP have been improved. However, the input method implementation in Avalonia appears to be based on the IMESharp code, which in turn follows logic originating from Chromium's code as early as 2008 or even earlier. Windows 7 was officially released on October 22, 2009, while Windows Vista was released on November 30, 2006.
Will Avalonia's Windows input method switch to TSF in the future? TSF has been a modern framework since Windows XP.
Perhaps we can also refer to the implementations of WPF (TSF) and modern Chromium (TSF).
If we implement TSF, it may potentially resolve many of the previous IME-related issues, though the workload would be significant.
realybin
changed the title
Fix incorrect ImeWindow position when using Pinyin IMEs
Fix incorrect ImeWindow position when using Pinyin IMEs in Windows
Apr 30, 2025
realybin
changed the title
Fix incorrect ImeWindow position when using Pinyin IMEs in Windows
Fix incorrect CandidateWindow position when using Pinyin IMEs in Windows
Apr 30, 2025
I noticed that version 11.3.0-rc1 has already been released. Would it be possible to merge this bug fix before the final release of version 11.3.0? We may consider implementing this via TSF in the future. Thank you for your time and consideration!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
realybin
changed the title
MrJul
added
the
backport-candidate-11.3.x
What does the pull request do?
This pull request addresses an issue where the IME CandidateWindow is not correctly positioned when using Pinyin IMEs on Windows. The fix ensures that the CandidateWindow aligns properly with the caret position, improving user experience when typing Chinese characters with Pinyin Input Method Editors.
What is the current behavior?
The CandidateWindow's top position does not align correctly with the caret position. This behavior is inconsistent with most major UI frameworks and leads to a poor user experience when inputting Chinese characters using Pinyin IMEs.
This issue was observed in different Chinese IMEs, including older ones on Windows 7.
What is the updated/expected behavior with this PR?
The CandidateWindow now aligns correctly with the caret position. This behavior has been tested on multiple Chinese IMEs, including those available on Windows 7, and all display as expected.
The fix ensures compatibility across various IMEs and improves usability.
How was the solution implemented (if it's not obvious)?
Most Chinese input methods after Windows XP have been improved. However, the input method implementation in Avalonia appears to be based on the IMESharp code, which in turn follows logic originating from Chromium's code as early as 2008 or even earlier. Windows 7 was officially released on October 22, 2009, while Windows Vista was released on November 30, 2006.
Will Avalonia's Windows input method switch to TSF in the future? TSF has been a modern framework since Windows XP.
Perhaps we can also refer to the implementations of WPF (TSF) and modern Chromium (TSF).
If we implement TSF, it may potentially resolve many of the previous IME-related issues, though the workload would be significant.
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #18748