Skip to content

Fix height queries not matching when container name is set, remove unused query grammer and allow nesting selector in container styles #18659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025

Conversation

emmauss
Copy link
Contributor

@emmauss emmauss commented Apr 15, 2025

What does the pull request do?

Fixes the following issues

  1. Height queries weren't setting their container name.
  2. There was some code used for cut query grammer still left over.
  3. Query in ControlThemes didn't allow styles to use nested operator. It still wouldn't apply the styles to the container since containers can't be styled by containing styles, but it shouldn't crash if a user decides to use them.

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@emmauss emmauss requested a review from grokys April 15, 2025 15:40
@MrJul MrJul added bug backport-candidate-11.3.x Consider this PR for backporting to 11.3 branch labels Apr 15, 2025
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 12.0.999-cibuild0056063-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 12.0.999-cibuild0056080-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@MrJul MrJul added this pull request to the merge queue Apr 17, 2025
Merged via the queue into master with commit b8e4be7 Apr 17, 2025
11 checks passed
@MrJul MrJul deleted the container-queries-fixes branch April 17, 2025 10:01
MrJul added a commit that referenced this pull request Apr 25, 2025
…used query grammer and allow nesting selector in container styles (#18659)

* fix height queries not matching when container name is set, remove unused query grammer

* add unit test for height container queries with name

---------

Co-authored-by: Julien Lebosquain <[email protected]>
@MrJul MrJul added backported-11.3.x and removed backport-candidate-11.3.x Consider this PR for backporting to 11.3 branch labels Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants