-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[Grid] Fix size calculation for ranges #18621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You can test this PR using the following package version. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
double requestedSize, | ||
double percentReferenceSize) | ||
double spacing, | ||
double desiredSize) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was really confused at the removal of percentReferenceSize
here (we ideally don't want to touch code that isn't related to spacing). But apparently this parameter was never used! It's the same thing in the original WPF source code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
* Fix size calculation for range * Add unit tests * Clean code * More correct fix * Clean code (remove unused params) * Delete accidentally added file
What does the pull request do?
This PR fixes the calculation of the size of merged cells when setting the RowSpan and ColumnSpan properties.
Sample code for sandbox:
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues