Fix Window.Show when MinWidth > MaxWidth #18604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJul
added
bug
regression
backport-candidate-11.3.x
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Apr 8, 2025
MrJul
added a commit
that referenced
this pull request
Apr 12, 2025
* Add failing Window test * Fix Window.Show when MinWidth > MaxWidth * Fix AboutAvaloniaDialog size constraints
MrJul
added
backported-11.3.x
and removed
backport-candidate-11.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes
Window.Showthrowing in 11.3 whenMinWidthis greater thanMaxWidth(also applies toMinHeight/MaxHeight).This used to work in previous versions: the issue was introduced by #16158.
A unit test has been added.
This PR also changes
AboutAvaloniaDialog, which had wrong dimensions (and where the bug was found).What is the current behavior?
Having
MinWidth/Heightgreater thanMaxWidth/MaxHeightthrows.What is the updated/expected behavior with this PR?
Having
MinWidth/Heightgreater thanMaxWidth/MaxHeightworks, with the maximum value winning.How was the solution implemented (if it's not obvious)?
The existing internal
MinMaxstructure is used, which already coerces the values properly.