Make mobile TryGetPlatformHandle consistent #18483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
enhancement
os-browser
os-ios
os-android
backport-candidate-11.2.x
|
You can test this PR using the following package version. |
maxkatz6
added
the
backport-candidate-11.1.x
kekekeks
approved these changes
Mar 20, 2025
MrJul
pushed a commit
that referenced
this pull request
Mar 29, 2025
* Use AndroidViewControlHandle for android toplevel handle * Use UIViewControlHandle for iOS toplevel handle * Use JSObjectControlHandle for browser toplevel handle * Revert NativeControlHostImpl changes
MrJul
added
backported-11.2.x
and removed
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
TopLevel.TryGetPlatformHandleis expected to return handle of the view/window where top level is hosted. That's how it works on desktop platforms, and is useful for interop integrations.On mobile, the same API couldn't be utilized to its potential, which this PR solves.
What is the current behavior?
iOS:
Browser:
Android:
PlatformImpl.Surfaces(private api).What is the updated/expected behavior with this PR?
iOS:
Browser:
<div/>reference.Android:
Breaking changes
Android.TryGetPlatformHandlereturns different type of handle now. But arguably, previous value wasn't useful.