Support complex types in datatype #18379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
bug
area-xaml
backport-candidate-11.2.x
This was referenced Mar 25, 2025
MrJul
pushed a commit
that referenced
this pull request
Mar 29, 2025
* Fix XamlTypeExtensionNode not being handled on the x:DataType transformer * Add testt with complex DataType * Make vm:MainWindowViewModel+TestItem nested type generic on BindingDemo
MrJul
added
backported-11.2.x
and removed
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
In 11.1 and 11.2 we greatly improved XAML type resolver scenarios, including nested types, generics and more.
Unfortunately, there are still some use cases containing bugs, like this one:
In this example, x:Type works as expected, and correct generic type is resolved. Unfortunately,
DataTypeitself for some reason wasn't expecting any complex markup extension, and thus failing this case.Checklist
This comment #391 (comment)