Fix TextLayout.Width calculation (#18305) #18310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
|
@cla-avalonia agree |
|
/cc @amwx if you want to test the build from this PR |
MrJul
added
bug
backport-candidate-11.2.x
robloo
reviewed
Feb 25, 2025
|
You can test this PR using the following package version. |
Gillibald
approved these changes
Feb 25, 2025
This was referenced Feb 26, 2025
MrJul
pushed a commit
that referenced
this pull request
Feb 28, 2025
MrJul
added
backported-11.2.x
and removed
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
TextLayout.UpdateMetricswas incorrectly calculating the Width for certain fonts. This caused a breaking change making11.2.3+not usable with certain projects.What is the updated/expected behavior with this PR?
The Width should be now correctly calculated.
How was the solution implemented (if it's not obvious)?
Separate the update of the bounds from the different metrics updated (
Width/Height...etc.)Checklist
Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
Fixes #18305
Fixes #17809