Don't alter any InputElement properties from in-process dnd handler #18288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kekekeks
added
the
backport-candidate-11.2.x
maxkatz6
approved these changes
Feb 22, 2025
|
You can test this PR using the following package version. |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
MrJul
pushed a commit
that referenced
this pull request
Feb 28, 2025
MrJul
added
backported-11.2.x
and removed
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our initial implementation of in-process drag-n-drop was altering the cursor of the control under the pointer and reverting it back after the drag operation was done. This didn't account for the other code potentially changing said cursor on the same element in the meantime.
This PR introduces an internal cursor override API for TopLevel that stores the temporary cursor in a field and uses it while the override is active.