Skip to content

In-process dnd should always handle pointermoved for consistency withactual dnd #18287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

kekekeks
Copy link
Member

@kekekeks kekekeks commented Feb 22, 2025

Actual DnD on windows and mac swallows any pointer movement events

Also see #18069

@kekekeks kekekeks added the backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch label Feb 22, 2025
@kekekeks kekekeks force-pushed the fixes/swallow-pointermove-in-inprocsource branch from 6023e4e to 52f953f Compare February 22, 2025 12:15
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0055056-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@kekekeks kekekeks added this pull request to the merge queue Feb 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 23, 2025
@MrJul MrJul added this pull request to the merge queue Feb 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 24, 2025
@kekekeks kekekeks merged commit e58c168 into master Feb 24, 2025
13 checks passed
@kekekeks kekekeks deleted the fixes/swallow-pointermove-in-inprocsource branch February 24, 2025 10:22
MrJul pushed a commit that referenced this pull request Feb 28, 2025
@MrJul MrJul added backported-11.2.x and removed backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch labels Feb 28, 2025
@mkmatis
Copy link

mkmatis commented Mar 31, 2025

I rely on PointerMovedEvent to update the position of a miniature of dragged control (more specifically, I subscribe to InputElement.PointerMovedEvent.Raised in an implementation of IDragHandler from Avalonia.Xaml.Interactions.DragAndDrop package). Now that the event is swallowed this no longer works.

Is there some preferred way how to draw custom items at pointer's position during drag and drop that would be compatible with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants