Skip to content

TextBox: clear selection when moving the caret horizontally #18255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2025
Merged

TextBox: clear selection when moving the caret horizontally #18255

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d99b89
TextBox: clear selection when moving the caret horizontally
rastislavsvoboda Feb 19, 2025
2f8b8e8
fix and add unit tests
rastislavsvoboda Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Avalonia.Controls/TextBox.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1983,6 +1983,14 @@ private void MoveHorizontal(int direction, bool wholeWord, bool isSelecting, boo
{
if (selectionStart != selectionEnd)
{
if (CaretIndex == SelectionStart)
{
// setting same value of SelectionEnd and SelectionStart will clear the selection first
// allowing to move the caret horizontally also in direction "away" from selection
SetCurrentValue(SelectionEndProperty, SelectionStart);
selectionEnd = SelectionEnd;
}

_presenter.MoveCaretToTextPosition(direction > 0 ?
Math.Max(selectionStart, selectionEnd) :
Math.Min(selectionStart, selectionEnd));
Expand Down