Skip to content

iterate over visible columns only when DnD column header #18251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

rastislavsvoboda
Copy link
Contributor

@rastislavsvoboda rastislavsvoboda commented Feb 19, 2025

What does the pull request do?

fixes DnD of column header in datagrid with invisible column(s)

What is the current behavior?

in datagrid with invisible column(s), when dragging column header, drop indicator is shown on wrong position

What is the updated/expected behavior with this PR?

drop indicator is shown on position of visible columns

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0054994-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@cla-avalonia
Copy link
Collaborator

cla-avalonia commented Feb 19, 2025

  • All contributors have signed the CLA.

@rastislavsvoboda
Copy link
Contributor Author

@cla-avalonia agree

Copy link
Member

@MrJul MrJul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

While the change looks good (there's no reason to take into account hidden columns while reordering), please provide an appropriate description for the PR next time so it's easy to understand why the change is needed.

@MrJul MrJul added this pull request to the merge queue Feb 21, 2025
Merged via the queue into AvaloniaUI:master with commit c1e0ba7 Feb 21, 2025
11 checks passed
@MrJul MrJul added the backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch label Feb 21, 2025
@rastislavsvoboda
Copy link
Contributor Author

Thank you for your contribution!

While the change looks good (there's no reason to take into account hidden columns while reordering), please provide an appropriate description for the PR next time so it's easy to understand why the change is needed.

sorry for that, I though I've filled it
updated

@MrJul MrJul added backported-11.2.x and removed backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch labels Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants